チャットが２行以上になると、最後までスクロールされないバグ修正 - #268
Merged
Merged
Conversation
chigichan24
requested changes
May 9, 2018
| val lastListPosition = adapter.itemCount - 1 | ||
| if (lastListPosition - 1 == lastVisiblePosition) { | ||
| binding.chatList.smoothScrollToPosition(lastListPosition) | ||
| binding.chatList.smoothScrollToPosition(lastListPosition + 1) |
Member
There was a problem hiding this comment.
というか範囲外を参照することで下までスクロールされるのまじか．．．
Member
There was a problem hiding this comment.
拡張関数としてsmoothScrolltoLastPositionみたいなのつくってせめてラップしましょう！
Collaborator
Author
There was a problem hiding this comment.
うーん、lastListPositionが結局adapter経由でしかわからないので、あまり綺麗にならなさそう
このあたりちゃんとViewModelに持ってくるべきな気がしてきた
でも、とりあえず下までスクロールされる形でリリースしたいので、一旦マージして別Issueで対処しませんか？
chigichan24
approved these changes
May 13, 2018
Member
|
別Issueを立てといてください |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #267
うーん…って感じ