Skip to content

チャットが２行以上になると、最後までスクロールされないバグ修正 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chigichan24 merged 1 commit into from
May 13, 2018
Merged

チャットが２行以上になると、最後までスクロールされないバグ修正 #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/kotlin/com/cyder/android/syncpod/view/fragment/ChatFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class ChatFragment : BaseFragment() {
val lastVisiblePosition = manager.findLastVisibleItemPosition()
val lastListPosition = adapter.itemCount - 1
if (lastListPosition - 1 == lastVisiblePosition) {
binding.chatList.smoothScrollToPosition(lastListPosition)
binding.chatList.smoothScrollToPosition(lastListPosition + 1)

@chigichan24 chigichan24 May 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここらへん算数すぎて泣きたくなる．

@chigichan24 chigichan24 May 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

というか範囲外を参照することで下までスクロールされるのまじか．．．

@chigichan24 chigichan24 May 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拡張関数としてsmoothScrolltoLastPositionみたいなのつくってせめてラップしましょう！

@mori-atsushi mori-atsushi May 10, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

算数できないの？

@mori-atsushi mori-atsushi May 10, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解

@mori-atsushi mori-atsushi May 11, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うーん、lastListPositionが結局adapter経由でしかわからないので、あまり綺麗にならなさそう
このあたりちゃんとViewModelに持ってくるべきな気がしてきた
でも、とりあえず下までスクロールされる形でリリースしたいので、一旦マージして別Issueで対処しませんか？

}
}
}
Expand Down