refactor:hpmn rename to evo - #10
Merged
Merged
Conversation
UdjinM6
requested changes
Oct 4, 2023
UdjinM6
left a comment
Contributor
There was a problem hiding this comment.
pls see below and maybe rename the file itself too (would have to adjust dashpay/dips#145 after that)
thephez
reviewed
Oct 4, 2023
thephez
left a comment
Collaborator
There was a problem hiding this comment.
Generally I would change:
- Evolution Node(s) -> Evolution masternode(s)
- EvoNode -> evonode
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Contributor
Author
Followed this guideline in order to be aligned with DIP-0028. |
thephez
requested changes
Oct 5, 2023
Co-authored-by: thephez <thephez@users.noreply.github.com>
Contributor
Author
Damn, I don't know how I managed to skip those 🙈 |
UdjinM6
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligned with DIP-0028 (dashpay/dips#145) and implementation (dashpay/dash#5508)