refactor: Global renaming from hpmn to evo by ogabrielides · Pull Request #5508 · dashpay/dash

ogabrielides · 2023-07-26T14:27:21Z

Issue being fixed or feature implemented

What was done?

Renaming of all classes/variables/functions/rpcs from hpmn to evo.

How Has This Been Tested?

All unit and func tests are passing.
Sync of Testnet.

Breaking Changes

All protx RPCs ending with _hpmn were converted to _evo.
_hpmn RPCs are now deprecated.
Although, they can still be enabled by adding -deprecatedrpc=hpmn.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

thephez

Generally, I think this substitution is better than just shortening to Evo:
HighPerformance -> Evolution

But not too concerned especially for internal stuff...

ogabrielides · 2023-07-26T15:17:28Z

Generally, I think this substitution is better than just shortening to Evo: HighPerformance -> Evolution

But not too concerned especially for internal stuff...

Let's gather everyone's opinion first.

knst · 2023-07-26T15:20:32Z

Let's gather everyone's opinion first.

"evo" is good for rpc, because shorter to type - better.
Docs/release node/some comments/logs - Evolution is better.
Name of internal variables - evo/evolution - both ways are fine

github-actions · 2023-07-28T05:21:41Z

This pull request has conflicts, please rebase.

ogabrielides · 2023-07-28T08:23:47Z

@UdjinM6 Your opinion ?

UdjinM6 · 2023-07-28T08:38:41Z

I'm fine with either option.

EDIT: It does add a bit of inconsistency though (rpc filters/fields use "evo")... 🤔

ogabrielides · 2023-07-28T08:41:32Z

@PastaPastaPasta @UdjinM6 @thephez @knst
Will implement the following then:

RPC names: evomn
Docs/release node/some comments/logs: Evolution
Internal variables: evolution

qwizzie · 2023-07-31T10:41:38Z

What about the Dash Core wallet ? It still shows 'Number of HPMN's' in the Windows - Information tab. Will this pull request change that to Evo ? Also the filter on tab Masternodes - Type state 'HighPerformance', will that be changed by this pull request as well ?

github-actions · 2023-08-01T04:55:06Z

This pull request has conflicts, please rebase.

Co-authored-by: thephez <thephez@users.noreply.github.com>

UdjinM6 · 2023-08-11T18:14:54Z

LGTM overall, pls see d16b7ee for a couple of small suggestions in comments

knst

re-utACK

Co-authored-by: thephez <thephez@users.noreply.github.com>

thephez

utACK

knst

re-utACK

UdjinM6

utACK

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

thephez

re-utACK

UdjinM6

re-utACK

PastaPastaPasta

utACK for squash merge

Relates to dashpay/dash#5508

* docs(rpc): convert protx hpmn commands to protx evo Relates to dashpay/dash#5508 * docs(rpc): minor change * docs(rpc): minor update

ogabrielides added the RPC Some notable changes to RPC params/behaviour/descriptions label Jul 26, 2023

ogabrielides requested review from PastaPastaPasta, UdjinM6, knst and thephez July 26, 2023 14:30

ogabrielides added this to the 20 milestone Jul 26, 2023

knst reviewed Jul 26, 2023

View reviewed changes

Comment thread test/functional/test_framework/test_framework.py Outdated

thephez reviewed Jul 26, 2023

View reviewed changes

Comment thread doc/release-notes-5508.md Outdated

Comment thread test/functional/test_framework/test_framework.py Outdated

Comment thread src/governance/object.cpp Outdated

PastaPastaPasta reviewed Jul 27, 2023

View reviewed changes

Comment thread doc/release-notes-5508.md Outdated

github-actions Bot added the needs rebase label Jul 28, 2023

github-actions Bot removed the needs rebase label Jul 28, 2023

github-actions Bot added the needs rebase label Aug 1, 2023

ogabrielides and others added 7 commits August 1, 2023 10:24

global refactoring hpmn to evo

5b8ceff

accept deprecated _hpmn rpcs

3215443

Create release-notes-5508.md

2c766f2

renamed EVONODE_COLLATERAL

8eb4ad1

Apply suggestions from code review

27e34ca

Co-authored-by: thephez <thephez@users.noreply.github.com>

conflict fix

a6268a0

Conflict fix

b603d41

github-actions Bot removed the needs rebase label Aug 1, 2023

suggestions

eb38ce4

ogabrielides dismissed knst’s stale review via 513ae2c August 17, 2023 11:24

ogabrielides requested review from PastaPastaPasta, knst and thephez August 17, 2023 11:26

linter fix

3ac2ea4

knst previously approved these changes Aug 17, 2023

View reviewed changes

thephez reviewed Aug 17, 2023

View reviewed changes

Comment thread src/rpc/evo.cpp Outdated

Update src/rpc/evo.cpp

51be2d3

Co-authored-by: thephez <thephez@users.noreply.github.com>

ogabrielides dismissed knst’s stale review via 51be2d3 August 17, 2023 13:28

ogabrielides requested review from knst and thephez August 17, 2023 13:29

thephez approved these changes Aug 17, 2023

View reviewed changes

knst previously approved these changes Aug 17, 2023

View reviewed changes

UdjinM6 previously approved these changes Aug 17, 2023

View reviewed changes

Comment thread src/rpc/evo.cpp Outdated

Update src/rpc/evo.cpp

5c4d393

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

ogabrielides dismissed stale reviews from UdjinM6 and knst via 5c4d393 August 17, 2023 15:24

ogabrielides requested review from UdjinM6, knst and thephez August 17, 2023 15:24

thephez approved these changes Aug 17, 2023

View reviewed changes

UdjinM6 approved these changes Aug 17, 2023

View reviewed changes

PastaPastaPasta approved these changes Aug 17, 2023

View reviewed changes

PastaPastaPasta merged commit 93f8df1 into dashpay:develop Aug 17, 2023

ogabrielides deleted the hpmn_to_evo branch August 18, 2023 07:52

thephez added a commit to thephez/docs-core that referenced this pull request Oct 3, 2023

docs(rpc): convert protx hpmn commands to protx evo

9e41c69

Relates to dashpay/dash#5508

thephez added a commit to dashpay/docs-core that referenced this pull request Oct 3, 2023

docs(rpc): update evonode protx docs (#71)

14e18f9

* docs(rpc): convert protx hpmn commands to protx evo Relates to dashpay/dash#5508 * docs(rpc): minor change * docs(rpc): minor update

This was referenced Oct 3, 2023

refactor: hpmn rename to evo for DIP-0028 dashpay/dips#145

Merged

refactor:hpmn rename to evo dashpay/FAQs#10

Merged

thephez added a commit to dashpay/docs-core that referenced this pull request Nov 15, 2023

docs(rpc): update evonode protx docs (#71)

5d93d53

* docs(rpc): convert protx hpmn commands to protx evo Relates to dashpay/dash#5508 * docs(rpc): minor change * docs(rpc): minor update

Uh oh!

Conversation

ogabrielides commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ogabrielides commented Jul 26, 2023

Uh oh!

knst commented Jul 26, 2023

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2023

Uh oh!

ogabrielides commented Jul 28, 2023

Uh oh!

UdjinM6 commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ogabrielides commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwizzie commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2023

Uh oh!

UdjinM6 commented Aug 11, 2023

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

knst left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ogabrielides commented Jul 26, 2023 •

edited

Loading

UdjinM6 commented Jul 28, 2023 •

edited

Loading

ogabrielides commented Jul 28, 2023 •

edited

Loading

qwizzie commented Jul 31, 2023 •

edited

Loading