Backport missing PRs from Bitcoin 0.14 - Part 1 - #1824
Merged
Conversation
UdjinM6
requested changes
Jan 1, 2018
There was a problem hiding this comment.
CDSNotificationInterface::SyncTransaction and underlying functions should be updated similarly too i.e. to use pindex and posInBlock
…or loop a3e1984 Consensus: Trivial transform BOOST_FOREACH into for loop (NicolasDorier)
…alCheckBlockHeader and ContextualCheckBlock 6f3d616 Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock (Jorge Timón)
cc021ef remove outdated legacy code (lizhi)
…oo low) faa5931 [doc] gbuild: Set memory explicitly (default is too low) (MarcoFalke)
d3af342 prepend license statement to indirectmap (Kaz Wesley)
893f379 [Qt] Add dbcache migration path (Jonas Schnelli)
fbc6070 [trivial] Switched constants to sizeof() (Thomas Snider)
d12b732 libconsensus: Expose a flag for BIP112 (Jorge Timón)
5c9e49d net: Ignore `notfound` P2P messages (Wladimir J. van der Laan)
a615386 [depends] ZeroMQ 4.1.5 (fanquake)
9bbb414 [qa]: enable rpcbind_test (whythat) 0ff4375 [qa]: add parsing for '<host>:<port>' argument form to rpc_url() (whythat)
…er main::CheckInputs a6cc299 Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs (Jorge Timón)
…nParams& in ContextualCheckBlock c8664ee Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (Jorge Timón)
29c2d99 Make CWallet::fFileBacked private. (Patrick Strateman)
b8db185 Update README.md (Chris Stewart)
657fc19 rename mapAddrCount to mapNetGroupNodes (instagibbs)
… guide 7fdbce9 [doc] Increase recommended memory in gitian build guide (fanquake)
2c517b3 Fix p2p-feefilter.py for changed tx relay behavior (Suhas Daftuar)
05242e9 Fix minimize and close bugs (adlawren)
e11f9a2 [doc] typos, READMEs, comments (Justin Camarena)
216d796 configure: Allow building bench_bitcoin by itself (Luke Dashjr)
…t any univalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
…llets b3b3c2a Reduce cs_main locks during ConnectTip/SyncWithWallets (Jonas Schnelli)
…nsaction Needed due to out-of-order backporting.
3897668 Adds issue template. [skip ci] (CryptoVote)
edb6cf1 remove no-longer-used InitError logic (instagibbs)
936c144 build: Remove check for `openssl/ec.h` (Wladimir J. van der Laan)
c1582d5 qa: Remove duplicate `hash160` implementation (Wladimir J. van der Laan)
6ffd996 Corrected JSON typo on setban of net.cpp (Sev)
8194a6e Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
1aacfc2 various typos (leijurv)
fa64306 [qa] abandonconflict: Use assert_equal (MarcoFalke)
This reverts commit fa2d68f. Temporary revert - see discussion in bitcoin#8532.
… directory" dialog b4a9aa5 qt: Fix random segfault when closing "Choose data directory" dialog (Wladimir J. van der Laan)
…inginfo RPC endpoint 65f4532 document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
Rename labelEncryptionIcon to labelWalletEncryptionIcon Reorder icons in Makefile.qt.include Add missing entries in debian/copyright
…tput printing fa785d1 Use __func__ to get function name for output printing (MarcoFalke)
faaec13 [qa] Remove unused code (MarcoFalke)
These were mixed into SegWit related PRs and are still needed in Dash.
codablock
force-pushed
the
pr_backport_bitcoin_0.14-1
branch
from
January 8, 2018 17:44
eebf8c8 to
e2a795f
Compare
Author
|
Added the requested changes and rebased on develop |
|
utACK |
| @@ -1628,6 +1643,17 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) | |||
|
|
|||
Member
There was a problem hiding this comment.
Why is this change missing?? https://github.com/bitcoin/bitcoin/pull/8392/files#diff-c865a8939105e6350a50af02766291b7R1304
There was a problem hiding this comment.
Because this is only useful to fix missing segwit data sipa@6032f69 which we don't have anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1770
This is the first batch of PRs from Bitcoin 0.14