Decouple lite mode and client-side PrivateSend by UdjinM6 · Pull Request #2893 · dashpay/dash

UdjinM6 · 2019-04-30T23:11:13Z

This allows client-side mixing on pruned nodes running in lite mode.

Redefines fEnablePrivateSend and -enableprivatesend:

off by default in lite mode and on in full mode (but can be overridden in both modes);
does not start mixing anymore.

Introduces fPrivateSendRunning and -privatesendautostart (default is off). Use this to start mixing automatically (or privatesend rpc to start mixing manually).

Also, privatesend_balance is shown in rpcs regardless of lite mode or PS state now.

UdjinM6 · 2019-05-23T11:46:46Z

Travis is green after manual restart https://travis-ci.org/UdjinM6/dash

PastaPastaPasta

One suggestion(that's not terribly relevant to this PR but 🤷‍♂️), otherwise utACK. didn't test tho

PastaPastaPasta

Testing on testnet commit ec8f7faa64 : works not in litemode, on litemode does~~n't~~ work.

Started client with ./dash-qt --testnet --litemode
In console privatesend start yields Mixing start failed: , will retry Starting with --privatesend didn't work either.

Hmm, forgot about the -enableprivatesend command, but still, I don't like that error message, not very clear that I need to enable privatesend via launch option

Alright, testing on litemode and it's working now with -enableprivatesend

UdjinM6 · 2019-05-29T18:58:34Z

Rebased to fix conflicts after #2936

PastaPastaPasta

There should be a better error message when attempting to start PS from non lite-mode client

codablock

See inline comments.

I'm also wondering if it actually makes sense to have -enableprivatesend at all if at the same time fPrivateSendRunning is actually controlling whether its running or not. What about removing all the conditionals around fEnablePrivateSend (treat it as if its always "enabled") and just handle fPrivateSendRunning? The only real effect this would have on users is that they can't disable the PS UI.

codablock · 2019-06-17T10:19:01Z

Maybe out of scope of this PR, but I have the feeling that this check and the corresponding = false should happen at inititialization time instead of here and this location should just check for !fEnablePrivateSend || !fPrivateSendRunning

cbf7caef629306246d979ecbb54da8e503b5efac kind of does the init part but I pushed more replacements for !pwalletMain just now.

codablock · 2019-06-17T10:43:21Z

Is the move of this into the !fEnablePrivateSend intended? If I'm not mistaken, this was present run in all cases before.

Same with updateInstantSend actually, but I assume it's ok in that case as you're moving it into the !fLiteMode case.

Yes, there is no reason to use connect for an invisible PS checkbox (which is the case when PS is disabled, line 93).

UdjinM6 · 2019-06-17T12:20:43Z

fEnablePrivateSend controls not only the UI but also some wallet code (which was initially the reason it was added back then when ps balance calculations was horribly slow).

codablock

utACK

PastaPastaPasta · 2019-06-24T17:24:59Z

Was there ever any change for the error message if a user launches in lightmode but doesn't -enableprivatesend and tries to run PS commands?

UdjinM6 · 2019-06-24T18:40:41Z

@PastaPastaPasta ah, I see what you mean now, wasn't clear before :)

UdjinM6 · 2019-06-24T19:04:39Z

Added 7050f08, pls re-review.

PastaPastaPasta

utack 7050f08

`-enableprivatesend`: 1. off by default in lite mode but can be overridden 2. does not start mixing, use `-privatesendautostart` (default is off) or `privatesend` rpc instead

…let is locked

… `!pwalletMain` in ps client code

…n mmixing is disabled

UdjinM6 · 2019-06-26T11:58:49Z

Rebased to fix merge conflicts after #2992 (added a couple of gArgs.s)

codablock

re-utACK

UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Apr 30, 2019

UdjinM6 modified the milestone: 14.0 May 1, 2019

UdjinM6 added this to the 14.1 milestone May 10, 2019

UdjinM6 force-pushed the decoupleps branch 2 times, most recently from 171617a to ec8f7fa Compare May 23, 2019 09:15

PastaPastaPasta reviewed May 23, 2019

View reviewed changes

Comment thread src/qt/sendcoinsdialog.cpp Outdated

PastaPastaPasta approved these changes May 23, 2019

View reviewed changes

PastaPastaPasta requested changes May 24, 2019

View reviewed changes

UdjinM6 force-pushed the decoupleps branch 4 times, most recently from 364d900 to cbf7cae Compare May 29, 2019 18:56

PastaPastaPasta requested changes May 29, 2019

View reviewed changes

UdjinM6 requested a review from codablock June 15, 2019 12:17

codablock reviewed Jun 17, 2019

View reviewed changes

UdjinM6 force-pushed the decoupleps branch from dec059c to 792c374 Compare June 18, 2019 12:26

codablock previously approved these changes Jun 24, 2019

View reviewed changes

UdjinM6 dismissed codablock’s stale review via 7050f08 June 24, 2019 19:03

PastaPastaPasta previously approved these changes Jun 24, 2019

View reviewed changes

UdjinM6 added 4 commits June 26, 2019 14:45

Decouple lite mode and client-side PrivateSend

b1f0f40

`-enableprivatesend`: 1. off by default in lite mode but can be overridden 2. does not start mixing, use `-privatesendautostart` (default is off) or `privatesend` rpc instead

Disable PS when there is no wallet, do not auto-start mixing when wal…

644f28a

…let is locked

Check for !fEnablePrivateSend and !fPrivateSendRunning instead of…

f996bdf

… `!pwalletMain` in ps client code

Add meaningful privatesend rpc error messages for various cases whe…

5ba5514

…n mmixing is disabled

UdjinM6 dismissed PastaPastaPasta’s stale review via 5ba5514 June 26, 2019 11:57

UdjinM6 force-pushed the decoupleps branch from 7050f08 to 5ba5514 Compare June 26, 2019 11:57

codablock approved these changes Jun 26, 2019

View reviewed changes

UdjinM6 merged commit b75e1ce into dashpay:develop Jun 27, 2019

UdjinM6 deleted the decoupleps branch November 26, 2020 13:25

Uh oh!

Conversation

UdjinM6 commented Apr 30, 2019

Uh oh!

UdjinM6 commented May 23, 2019

Uh oh!

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented May 29, 2019

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

codablock left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codablock Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

UdjinM6 Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codablock Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

codablock Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

UdjinM6 Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta commented Jun 24, 2019

Uh oh!

UdjinM6 commented Jun 24, 2019

Uh oh!

UdjinM6 commented Jun 24, 2019

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Jun 26, 2019

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PastaPastaPasta left a comment •

edited

Loading

codablock left a comment •

edited

Loading

UdjinM6 Jun 17, 2019 •

edited

Loading

UdjinM6 commented Jun 17, 2019 •

edited

Loading