Remove references to instantx and darksend in sendcoinsdialog.cpp - #2936
Merged
UdjinM6 merged 2 commits intoMay 29, 2019
Merged
Conversation
UdjinM6
requested changes
May 23, 2019
UdjinM6
left a comment
There was a problem hiding this comment.
Can't just replace one with another, should check old settings first and, if they exist, re-apply their values to new ones. Otherwise it would be equivalent to partial settings reset.
PastaPastaPasta
force-pushed
the
remove-instantx-darksend-sendcoinsdialog
branch
from
May 23, 2019 17:46
98eff81 to
2efadd8
Compare
Member
Author
I just figured resetting those settings wouldn't be that big of a deal. Afterall, you should review them every time you make a tx |
… be backwords compatible Signed-off-by: Pasta <Pasta@dash.org>
PastaPastaPasta
force-pushed
the
remove-instantx-darksend-sendcoinsdialog
branch
from
May 23, 2019 17:50
2efadd8 to
a5bb147
Compare
UdjinM6
requested changes
May 24, 2019
UdjinM6
left a comment
There was a problem hiding this comment.
Looks like my suggestions were incomplete 🙈
Signed-off-by: Pasta <Pasta@dash.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.