[monodroid] Do not build host or classic runtimes#8256
Merged
Conversation
The `monodroid` build has been updated to only build the runtime files that ship with .NET Android. The generated `cmake-config.props` and `cmake-monodroid.targets` files that determined which runtimes to build have had their content migrated directly into `monodroid.targets`. The corresponding generation logic in `xaprepare` has been removed. The `build-tools/scripts/build-monodroid` script and its dependencies have been removed as they did not appear to be used anywhere.
grendello
reviewed
Aug 9, 2023
grendello
approved these changes
Aug 9, 2023
jonathanpeppers
approved these changes
Aug 9, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 10, 2023
* main: [Mono.Android.dll] Fix [SupportedOSPlatform] warnings. (dotnet#8247) Bump to xamarin/monodroid/main@a5248591 (dotnet#8258) [Mono.Android] Bind `java.time` and `java.time.chrono` packages. (dotnet#8088) Bump to xamarin/Java.Interop/main@5adb4d4 (dotnet#8251) [ci] Use fewer agents for macOS MSBuild tests (dotnet#8257) [ci] Report when dotnet-test-slicer fails (dotnet#8259) [monodroid] Do not build host or classic runtimes (dotnet#8256)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
monodroidbuild has been updated to only build the runtime filesthat ship with .NET Android.
The generated
cmake-config.propsandcmake-monodroid.targetsfilesthat determined which runtimes to build have had their content migrated
directly into
monodroid.targets. The corresponding generation logicin
xapreparehas been removed.The
build-tools/scripts/build-monodroidscript and its dependencieshave been removed as they did not appear to be used anywhere.
xabuild.csprojwill no longer be built as part ofmake jenkins.