[ci] Report when dotnet-test-slicer fails#8259
Merged
Merged
Conversation
Changes to the `dotnet-test-slicer` task from commit a427688 may have caused it to fail silently if any issues occur. Updating the task to fail if anything is written to stderr should fix this.
jpobst
approved these changes
Aug 10, 2023
jpobst
left a comment
Contributor
There was a problem hiding this comment.
I don't think we need separate logic for if it has a filter or not. If the filter is omitted or empty, it should be ignored:
Member
Author
|
Unfortunately if the param is passed but empty the the argument parser library reports an error and exits before it can get there:
|
Contributor
|
Huh, guess that's something |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 10, 2023
* main: [Mono.Android.dll] Fix [SupportedOSPlatform] warnings. (dotnet#8247) Bump to xamarin/monodroid/main@a5248591 (dotnet#8258) [Mono.Android] Bind `java.time` and `java.time.chrono` packages. (dotnet#8088) Bump to xamarin/Java.Interop/main@5adb4d4 (dotnet#8251) [ci] Use fewer agents for macOS MSBuild tests (dotnet#8257) [ci] Report when dotnet-test-slicer fails (dotnet#8259) [monodroid] Do not build host or classic runtimes (dotnet#8256)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the
dotnet-test-slicertask from commit a427688 may havecaused it to fail silently if any issues occur. Updating the task to
fail if anything is written to stderr should fix this.