Remove redundant rolling build pipeline parameter - #133068
Merged
Merged
Conversation
Use the common isRollingBuild variable directly in the extra-platform WASM template and remove the unused parameter from extra-platform templates and their callers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 537135b4-f893-4193-b5d6-cd1d99d6c44e
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
premun
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly removes redundant parameter wiring and all current callers already import the common variables template that defines isRollingBuild.
Pull request overview
Removes the redundant isRollingBuild parameter plumbing from extra-platform pipeline wrappers and templates by relying on the shared variables.isRollingBuild value defined in eng/pipelines/common/variables.yml.
Changes:
- Stop passing
isRollingBuildfrom wrapper pipelines into extra-platform templates. - Remove the unused
isRollingBuildparameter from extra-platform templates; update the WASM extra-platform template to usevariables.isRollingBuilddirectly.
File summaries
| File | Description |
|---|---|
| eng/pipelines/runtime-wasm.yml | Removes isRollingBuild parameter pass-through to the WASM extra-platform template. |
| eng/pipelines/runtime-wasm-optional.yml | Removes isRollingBuild parameter pass-through to the WASM extra-platform template. |
| eng/pipelines/runtime-wasm-non-libtests.yml | Removes isRollingBuild parameter pass-through to the WASM extra-platform template. |
| eng/pipelines/runtime-wasm-libtests.yml | Removes isRollingBuild parameter pass-through to the WASM extra-platform template. |
| eng/pipelines/runtime-wasm-dbgtests.yml | Removes isRollingBuild parameter pass-through to the WASM extra-platform template. |
| eng/pipelines/runtime-maccatalyst.yml | Removes isRollingBuild parameter pass-through to the Mac Catalyst extra-platform template. |
| eng/pipelines/runtime-linuxbionic.yml | Removes isRollingBuild parameter pass-through to the Linux Bionic extra-platform template. |
| eng/pipelines/runtime-ioslikesimulator.yml | Removes isRollingBuild parameter pass-through to the iOS-like simulator extra-platform template. |
| eng/pipelines/runtime-ioslike.yml | Removes isRollingBuild parameter pass-through to the iOS-like extra-platform template. |
| eng/pipelines/runtime-extra-platforms.yml | Removes isRollingBuild parameter pass-through from the extra-platforms pipeline to its component templates. |
| eng/pipelines/runtime-androidemulator.yml | Removes isRollingBuild parameter pass-through to the Android emulator extra-platform template. |
| eng/pipelines/runtime-android.yml | Removes isRollingBuild parameter pass-through to the Android extra-platform template. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml | Drops isRollingBuild parameter and switches conditional logic to variables.isRollingBuild. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml | Drops unused isRollingBuild parameter from template parameters. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-linuxbionic.yml | Drops unused isRollingBuild parameter from template parameters. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml | Drops unused isRollingBuild parameter from template parameters. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml | Drops unused isRollingBuild parameter from template parameters. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-androidemulator.yml | Drops unused isRollingBuild parameter from template parameters. |
| eng/pipelines/extra-platforms/runtime-extra-platforms-android.yml | Drops unused isRollingBuild parameter from template parameters. |
Review details
- Files reviewed: 19/19 changed files
- Comments generated: 0
- Review effort level: Lite
maraf
approved these changes
Sep 2, 2026
This was referenced Sep 2, 2026
radekdoulik
added a commit
that referenced
this pull request
Sep 25, 2026
## Problem The scheduled `runtime-extra-platforms` pipeline includes this child template only for rolling builds, but since #133068 the child has repeated that check through `variables.isRollingBuild`. That ambient variable is unavailable during nested compile-time expansion, so it expands empty and the child selects the WASM-specific branches instead. Build 1610154 consequently omitted `LibraryTestsCoreCLR_R2R` and `TestWasmReadyToRun` while adding `SingleThreaded_BuildOnly` and non-extra browser CoreCLR jobs. ## Fix Use the explicit `isExtraPlatformsBuild` parameter to select the scheduled extra-platforms branch and its inverse for WASM-specific pipeline invocations. Use the explicit `isWasmOnlyBuild` parameter for WASI smoke `alwaysRun` behavior. ## Validation - parsed `eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml` successfully as YAML - authenticated Azure DevOps definition 154 preview against the PR merge ref includes `LibraryTestsCoreCLR_R2R` and `TestWasmReadyToRun` - preview includes both browser smoke AOT jobs, both WASI AOT jobs, and both browser high-resource AOT jobs - preview contains no `SingleThreaded_BuildOnly` references and no non-extra browser CoreCLR build-only jobs - no pipeline run was queued; validation used the preview API only `/azp run runtime-extra-platforms` cannot validate this scheduled path on a PR: PR runs set `Build.Reason` to `PullRequest`, which makes the root `isRollingBuild` gate omit the WASM child template entirely. The preview API expands definition 154 against the PR merge ref in the required rolling context without queuing a build. The next daily scheduled run after merge will provide the end-to-end confirmation. > [!NOTE] > This pull request description was generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 541a2c0a-365a-40d8-adfc-20e687d223b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the common isRollingBuild variable directly in the extra-platform WASM template and remove the unused parameter from extra-platform templates and their callers.
Noticed in #133002
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com