Fix scheduled WASM extra-platforms job selection - #134613
Merged
radekdoulik merged 1 commit intoSep 25, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 541a2c0a-365a-40d8-adfc-20e687d223b8
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues were identified; only a minor comment clarification remains.
Review effort: Lite
Findings: None
What changed in this PR
Fixes scheduled WASM extra-platform job selection by using explicit template parameters.
Changes:
- Uses
isExtraPlatformsBuildfor extra-platform branches. - Uses
isWasmOnlyBuildfor WASI smoke behavior. - Updates related pipeline conditions and comments.
| File | Summary |
|---|---|
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml |
Corrects parameter-based WASM job selection; one minor comment update was noted. |
akoeplinger
approved these changes
Sep 25, 2026
Member
Author
|
/ba-g the failures are unrelated, pre-existing on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled
runtime-extra-platformspipeline includes this child template only for rolling builds, but since #133068 the child has repeated that check throughvariables.isRollingBuild. That ambient variable is unavailable during nested compile-time expansion, so it expands empty and the child selects the WASM-specific branches instead. Build 1610154 consequently omittedLibraryTestsCoreCLR_R2RandTestWasmReadyToRunwhile addingSingleThreaded_BuildOnlyand non-extra browser CoreCLR jobs.Fix
Use the explicit
isExtraPlatformsBuildparameter to select the scheduled extra-platforms branch and its inverse for WASM-specific pipeline invocations. Use the explicitisWasmOnlyBuildparameter for WASI smokealwaysRunbehavior.Validation
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.ymlsuccessfully as YAMLLibraryTestsCoreCLR_R2RandTestWasmReadyToRunSingleThreaded_BuildOnlyreferences and no non-extra browser CoreCLR build-only jobs/azp run runtime-extra-platformscannot validate this scheduled path on a PR: PR runs setBuild.ReasontoPullRequest, which makes the rootisRollingBuildgate omit the WASM child template entirely. The preview API expands definition 154 against the PR merge ref in the required rolling context without queuing a build. The next daily scheduled run after merge will provide the end-to-end confirmation.Note
This pull request description was generated with GitHub Copilot.