Disable runtime thread reinitilization check on Apple platforms - #134609
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Apple thread cleanup and regression coverage need to be addressed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Disables the Apple thread-state reinitialization check and excludes the related macOS regression test.
Changes:
- Bypasses
CheckThreadStateNotDestroyed()on Apple. - Marks the regression test unsupported on macOS.
| File | Summary |
|---|---|
src/coreclr/vm/threads.cpp |
Apple re-entry requires explicit attach/detach handling or re-armed cleanup. |
src/tests/baseservices/threading/ThreadStateDestroyed/ThreadStateDestroyed.csproj |
Update Apple coverage to validate successful re-entry rather than excluding the test. |
jkotas
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling this check per #134571.