Skip to content

Disable runtime thread reinitilization check on Apple platforms #134609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eduardo-vp merged 1 commit into from
Sep 25, 2026
+6 −0
Merged

Disable runtime thread reinitilization check on Apple platforms #134609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coreclr/vm/threads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,11 @@ Thread* SetupThread()
if ((pThread = GetThreadNULLOk()) != NULL)
return pThread;

#ifndef TARGET_APPLE
// Disable the check on Apple platforms
// See https://github.com/dotnet/runtime/issues/134571
CheckThreadStateNotDestroyed();
#endif
Comment thread
eduardo-vp marked this conversation as resolved.

// For interop debugging, we must mark that we're in a can't-stop region
// b.c we may take Crsts here that may block the helper thread.
Expand Down
2 changes: 2 additions & 0 deletions src/tests/baseservices/threading/ThreadStateDestroyed/ThreadStateDestroyed.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<GCStressIncompatible>true</GCStressIncompatible>
<NativeAotIncompatible>true</NativeAotIncompatible>
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true' or '$(TargetsAndroid)' == 'true' or '$(TargetsBrowser)' == 'true' or '$(TargetsWasi)' == 'true'">true</CLRTestTargetUnsupported>
<!-- ActiveIssue https://github.com/dotnet/runtime/issues/134571 -->
<CLRTestTargetUnsupported Condition="'$(TargetsOSX)' == 'true'">true</CLRTestTargetUnsupported>
Comment thread
eduardo-vp marked this conversation as resolved.
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' != 'coreclr'">true</CLRTestTargetUnsupported>
</PropertyGroup>
<ItemGroup>
Expand Down
Loading