Ensure that all paths of double.Hypot use the absolute value where required - #75776
Merged
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
tannergooding
commented
Sep 16, 2022
| { | ||
| // x or y is insignificant compared to the other | ||
| result = x + y; | ||
| result = ax + ay; |
Member
Author
There was a problem hiding this comment.
The original C algorithm uses 'x' and 'y', but does so after having reassigned them to be the absolute value.
That is, it effectively does x = abs(x), y = abs(y).
I double checked other usages of x/y and they are all fine/correct.
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves #75651
|
stephentoub
reviewed
Sep 16, 2022
stephentoub
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #75651