Skip to content

fix(orchestrator): restore //go:build linux tags on template metadata package #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdaAibaby wants to merge 2 commits into from
Closed

fix(orchestrator): restore //go:build linux tags on template metadata package #3342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec95729
fix(orchestrator): restore //go:build linux tags on template metadata…
adababys Jul 23, 2026
aa9e801
Merge branch 'main' into fix/template-metadata-linux-build-tags
AdaAibaby Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/orchestrator/cmd/copy-build/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// copy-build requires Linux. The template metadata package imports
// sandbox/block which uses Linux-only syscalls (userfaultfd, memfd).
// Darwin support is blocked on separating the cross-platform data types
// from the Linux-only implementation; tracked in issue #3316.
package main

import (
Expand Down
3 changes: 3 additions & 0 deletions packages/orchestrator/pkg/template/metadata/prefetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
//go:build linux

// See template_metadata.go for why this file is restricted to Linux.
package metadata

import (
Expand Down
6 changes: 6 additions & 0 deletions packages/orchestrator/pkg/template/metadata/template_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
//go:build linux

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep template metadata available off Linux

On Darwin, the documented go run ./cmd/copy-build command imports this package, but these are its only two non-test files; constraining both to Linux makes Go reject the import because all package files are excluded. pkg/sandbox/block/prefetch_tracker.go is already cross-platform and provides the data types used here, so these tags should remain removed or portable metadata files must be provided.

Useful? React with 👍 / 👎.


// The build tag above restricts this file to Linux because it imports
// sandbox/block, which depends on Linux-only syscalls. Once the cross-platform
// data types are separated from the Linux-only block implementation (issue #3316),
// this tag can be removed.
package metadata

import (
Expand Down