Conversation
5aad415 to
d71980e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ffdba6df1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +1,5 @@ | |||
| //go:build linux | |||
There was a problem hiding this comment.
On Darwin, the documented go run ./cmd/copy-build command imports this package, but these are its only two non-test files; constraining both to Linux makes Go reject the import because all package files are excluded. pkg/sandbox/block/prefetch_tracker.go is already cross-platform and provides the data types used here, so these tags should remain removed or portable metadata files must be provided.
Useful? React with 👍 / 👎.
|
I am bit surprised with this as I think I tested it with |
|
Anyway, #3299 should have add only those parts from block and metadata packages that should be OS agnostic. |
… package template_metadata.go and prefetch.go import packages/orchestrator/pkg/sandbox/block which is Linux-only. The build constraints were dropped in a prior refactor, causing compilation failures on Darwin and other non-Linux platforms. Fixes e2b-dev#3316
5ffdba6 to
ec95729
Compare
|
I don't think this is fixing the real issue, see my comments in related issue #3316, |
Summary
packages/orchestrator/pkg/template/metadata/template_metadata.goandprefetch.goboth importpackages/orchestrator/pkg/sandbox/block, which is a Linux-only package (all its files carry//go:build linux).//go:build linuxat the top of both files.Fixes #3316
Test plan
go build ./packages/orchestrator/...passes on Linux (verified on dev)GOOS=darwin go build ./packages/orchestrator/...no longer fails on the metadata package/cc @jakubno @dobrac @ValentaTomas @arkamar @tvi Looking forward to your code review.