Major reorganization on flow to create/display newComment form - #72
Merged
Merged
Conversation
added 2 commits
July 16, 2015 17:07
As a result, some bugs were fixed: - #49, second part; - not allowing user to add comment if no text is selected; - cleaning form if user didn't click Cancel button to add a new comment on another text selection.
lpagliari
added a commit
that referenced
this pull request
Jul 17, 2015
Major reorganization on flow to create/display newComment form
JohnMcLear
added a commit
that referenced
this pull request
Sep 21, 2026
Lockfile-only refresh; no manifest or source change was needed, every vulnerable package was transitive and already in range. Runtime scope: - undici 7.24.8 -> 7.29.1 (transitive via cheerio). Clears all twelve runtime alerts: TLS certificate validation bypass (#58), SOCKS5 cross-origin request routing (#59), WebSocket fragment DoS (#62), cross-user cache disclosure (#57, #71, #73), response queue poisoning (#60), Set-Cookie header injection / SameSite downgrade (#61, #63, #74), response desynchronization on retry (#72) and blob-type CRLF injection (#75). Development scope: - form-data 4.0.6 (#56), qs 6.16.0 (#52), ws 8.21.3 (#54), socket.io-parser 4.2.7 (#78), js-yaml 4.3.2 (#64, #65, #79, #82), brace-expansion 1.1.21 (#66). Nothing was held back; no override was needed. Testing: backend suite run against an Etherpad core checkout before and after the refresh gives identical results (82 passing, 5 pending, 14 failing -- the 14 are pre-existing in this environment and unchanged by the bump). `pnpm run lint` passes with the same 125 pre-existing warnings and 0 errors. Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result, some bugs were fixed: