Remove '*' in the field 'suggested change from' - #82
Conversation
When we've a selection with a text with some line attribute applied, for example a list, and press a button to comment, the field 'suggest change from' shows asterisks in the beginning of line.
|
As @joassouza and I had discussed by email, he'll submit some improvements to this PR before it is approved. |
|
+1 :) Thanks! |
|
Hello everyone. I've been monitoring the ep_comments conversations, and when I saw this pop up on my screen I instantly wondered where the ep_page_view surrounding box was in @joassouza 's screenshot. How critical is it for ep_page_view to be installed for the ep_comments to work? Are they deeply intertwined? If I ditch ep_page_view from my mix, is that going to leave me with functionality problems, other than just needing a gutter on the right for comment icons, if enabled? |
|
@DanielBickley icons won't work properly without ep_page_view because you'll end with some icons in the middle of your text. Regarding ep_comments functionality, I guess it would work properly (@JohnMcLear might have the most correct answer), or at least I cannot think of anything else (besides icons) that would not work if you don't install ep_page_view on your instance. |
|
It should work fine w/ out page view as it did before but IDK re latest changes. Did you bother to test it before asking? |
|
Hey @JohnMcLear can you take look on this PR, I already did the improvements @lpagliari mentioned. =) |
Remove '*' in the field 'suggested change from'
Lockfile-only refresh; no manifest or source change was needed, every vulnerable package was transitive and already in range. Runtime scope: - undici 7.24.8 -> 7.29.1 (transitive via cheerio). Clears all twelve runtime alerts: TLS certificate validation bypass (#58), SOCKS5 cross-origin request routing (#59), WebSocket fragment DoS (#62), cross-user cache disclosure (#57, #71, #73), response queue poisoning (#60), Set-Cookie header injection / SameSite downgrade (#61, #63, #74), response desynchronization on retry (#72) and blob-type CRLF injection (#75). Development scope: - form-data 4.0.6 (#56), qs 6.16.0 (#52), ws 8.21.3 (#54), socket.io-parser 4.2.7 (#78), js-yaml 4.3.2 (#64, #65, #79, #82), brace-expansion 1.1.21 (#66). Nothing was held back; no override was needed. Testing: backend suite run against an Etherpad core checkout before and after the refresh gives identical results (82 passing, 5 pending, 14 failing -- the 14 are pre-existing in this environment and unchanged by the bump). `pnpm run lint` passes with the same 125 pre-existing warnings and 0 errors. Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
When we've a text selected with some line attribute applied,
for example a list, and press a button to comment, the field
'suggest change from' shows asterisks in the beginning of line.