🚑 server: drop unused payment rails field - #1025
Conversation
🦋 Changeset detectedLatest commit: 618a497 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
WalkthroughThe PR removes the ChangesPayment Rails Field Removal
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request removes the payment_rails field from the VirtualAccount schema and its associated mock data in the test suite. The PaymentRail constant has been deleted, and the source_deposit_instructions for USD, EUR, MXN, BRL, and GBP currencies have been updated to reflect this change. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 72.87% 72.94% +0.07%
==========================================
Files 241 241
Lines 9945 9990 +45
Branches 3246 3260 +14
==========================================
+ Hits 7247 7287 +40
- Misses 2406 2410 +4
- Partials 292 293 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Refactor
Tests
Chores