Skip to content

🚑 server: drop unused payment rails field - #1025

Merged
cruzdanilo merged 1 commit into
mainfrom
rails
May 19, 2026
Merged

🚑 server: drop unused payment rails field#1025
cruzdanilo merged 1 commit into
mainfrom
rails

Conversation

@mainqueg

@mainqueg mainqueg commented May 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Refactor

    • Simplified payment instruction validation by removing an unused field across several currency corridors.
  • Tests

    • Updated test fixtures to match the revised validation schema.
  • Chores

    • Added release metadata noting the patch-level update.

Review Change Stack

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 618a497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6442d4ad-bb44-4c33-86ec-d8712bae2aed

📥 Commits

Reviewing files that changed from the base of the PR and between a0a83e0 and 618a497.

📒 Files selected for processing (3)
  • .changeset/easy-teeth-flow.md
  • server/test/utils/bridge.test.ts
  • server/utils/ramps/bridge.ts
💤 Files with no reviewable changes (2)
  • server/test/utils/bridge.test.ts
  • server/utils/ramps/bridge.ts

Walkthrough

The PR removes the payment_rails field from the virtual account domain. The exported PaymentRail constant is deleted from bridge.ts, and the VirtualAccount schema no longer validates a payment_rails field within each fiat currency's deposit instructions variant. Mock virtual account fixtures in tests are updated to match.

Changes

Payment Rails Field Removal

Layer / File(s) Summary
Schema constant and field definitions
server/utils/ramps/bridge.ts, .changeset/easy-teeth-flow.md
The exported PaymentRail constant is removed. The VirtualAccount valibot schema for source_deposit_instructions is updated to remove the payment_rails field from BRL, EUR, MXN, and GBP currency-specific variant cases; a changeset entry records the patch bump.
Test fixture alignment
server/test/utils/bridge.test.ts
Mock virtual account fixtures for USD, EUR, MXN, BRL, and GBP are updated to remove payment_rails arrays from each source_deposit_instructions block.

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Possibly related PRs:

    • exactly/exa#814: Introduced/defined bridge payment-rail-related types that this PR further refines by removing the PaymentRail export and dropping payment_rails from source_deposit_instructions.
  • Suggested reviewers:

    • cruzdanilo
    • nfmelendez
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'drop unused payment rails field' accurately describes the main change: removing the payment_rails field from the codebase across multiple files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rails

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the payment_rails field from the VirtualAccount schema and its associated mock data in the test suite. The PaymentRail constant has been deleted, and the source_deposit_instructions for USD, EUR, MXN, BRL, and GBP currencies have been updated to reflect this change. I have no feedback to provide.

@sentry

sentry Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.94%. Comparing base (4a80e4e) to head (618a497).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   72.87%   72.94%   +0.07%     
==========================================
  Files         241      241              
  Lines        9945     9990      +45     
  Branches     3246     3260      +14     
==========================================
+ Hits         7247     7287      +40     
- Misses       2406     2410       +4     
- Partials      292      293       +1     
Flag Coverage Δ
e2e 72.76% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo
cruzdanilo marked this pull request as ready for review May 19, 2026 22:38
@cruzdanilo
cruzdanilo requested a review from nfmelendez as a code owner May 19, 2026 22:38
@cruzdanilo
cruzdanilo self-requested a review as a code owner May 19, 2026 22:39
@cruzdanilo
cruzdanilo merged commit 618a497 into main May 19, 2026
9 of 12 checks passed
@cruzdanilo
cruzdanilo deleted the rails branch May 19, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants