fix: use /person/infos for team member name resolution#10
Merged
Conversation
Add full team management support to the SDK: - TeamItem type with all 13 fields from /team/info endpoint - TeamGetInput, TeamUpsertInput, TeamUpsertOutput, TeamDeleteInput types - GetTeamInfo: parallel /team/info + /team/infos calls for full metadata with member names - UpsertTeam: create or update teams via /team/upsert - DeleteTeam: delete teams by ID, name, or ref_id via /team/delete - Enhanced ListTeamsInput with Limit, OrderBy, Asc, PersonID fields - OrderBy validation and limit capping (max 100)
The API requires team_name on every upsert call, even for updates. Add explicit validation in the SDK to fail fast with a clear error.
The /team/infos endpoint returns person_ids but not member names/emails for member-level app keys. Switch to /person/infos which reliably returns person details regardless of app key type. Changes: - GetTeamInfo: replace parallel /team/infos call with sequential /person/infos enrichment after /team/info returns person_ids. Also enrich creator_name when the API returns it empty. - ListTeams: parse person_ids from API response (not members), then batch-resolve via new enrichTeamMembers helper. - TeamInfo: add PersonIDs field to carry raw IDs from API. - Remove fetchTeamMembers helper (no longer needed). - Update TestListTeamsByIDsPreservesMembers to mock /person/infos.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/person/infosinstead of/team/infos/team/infosendpoint returnsperson_idsbut no member names/emails for member-level app keys/person/infosreliably returns person details regardless of app key typecreator_namewhen the API returns it emptyPersonIDsfield toTeamInfostruct for list/batch endpointsTest plan
go test -race ./...passesflashduty team get --id <id>shows member names and emailsflashduty team listshows member names in MEMBERS columnflashduty team get --id <id> --jsonreturns enriched members arraycreator_name