Skip to content

fix: use /person/infos for team member name resolution #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debidong merged 3 commits into from
May 14, 2026
Merged

fix: use /person/infos for team member name resolution #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8807835
feat: add team CRUD SDK methods (GetTeamInfo, UpsertTeam, DeleteTeam)
debidong May 14, 2026
d6be584
fix: require team_name in UpsertTeam and validate upfront
debidong May 14, 2026
a192294
fix: use /person/infos for team member name resolution
debidong May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 35 additions & 29 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,39 +123,45 @@ func callListTeams(t *testing.T, c *Client) {
func TestListTeamsByIDsPreservesMembers(t *testing.T) {
cap := &capturedHeaders{}
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path != "/team/infos" {
t.Fatalf("unexpected path: %s", r.URL.Path)
}

var body struct {
TeamIDs []int64 `json:"team_ids"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
t.Fatalf("decode request: %v", err)
}
if len(body.TeamIDs) != 2 || body.TeamIDs[0] != 101 || body.TeamIDs[1] != 202 {
t.Fatalf("unexpected team_ids payload: %#v", body.TeamIDs)
}

cap.set(r.Header)
w.Header().Set("Content-Type", "application/json")
_ = json.NewEncoder(w).Encode(map[string]any{
"data": map[string]any{
"items": []any{
map[string]any{
"team_id": 101,
"team_name": "alpha",
"members": []any{
map[string]any{
"person_id": 1,
"person_name": "Ada",
"email": "ada@example.com",
},
switch r.URL.Path {
case "/team/infos":
var body struct {
TeamIDs []int64 `json:"team_ids"`
}
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
t.Fatalf("decode request: %v", err)
}
if len(body.TeamIDs) != 2 || body.TeamIDs[0] != 101 || body.TeamIDs[1] != 202 {
t.Fatalf("unexpected team_ids payload: %#v", body.TeamIDs)
}
cap.set(r.Header)
_ = json.NewEncoder(w).Encode(map[string]any{
"data": map[string]any{
"items": []any{
map[string]any{
"team_id": 101,
"team_name": "alpha",
"person_ids": []int64{1},
},
},
},
},
})
})
case "/person/infos":
_ = json.NewEncoder(w).Encode(map[string]any{
"data": map[string]any{
"items": []any{
map[string]any{
"person_id": 1,
"person_name": "Ada",
"email": "ada@example.com",
},
},
},
})
default:
t.Fatalf("unexpected path: %s", r.URL.Path)
}
}))
defer ts.Close()

Expand Down
Loading