Skip to content

Fix signup issues - #574

Merged
georgelgeback merged 1 commit into
mainfrom
fix-event-signup-bugs
Aug 31, 2026
Merged

Fix signup issues#574
georgelgeback merged 1 commit into
mainfrom
fix-event-signup-bugs

Conversation

@georgelgeback

@georgelgeback georgelgeback commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

This PR changes the following:

  • Block a signup with default priority if a user has a higher priority which is used by the event
  • Handing out spots to users with the automatic route doesn't break anymore if prioritized users > max event users
  • Signups with null as priority are cast to default priority, which means people can be blocked by the rule above even when sending null or no field. I checked frontend and backend, and this should be fine.

Changes to the actual code is +22 -7, the rest are tests for regression.

…rity which is used by the event, fix bug with overflow of prioritized users

@hannesblaman hannesblaman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgelgeback
georgelgeback merged commit 17d6fa7 into main Aug 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants