Allow all members to sign up to nollning events - #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should only change things for people who hold no prioritized posts and who are not members of the nollning, they can now sign up. People who are members of the nollning still have to enter their priority correctly etc. (all the tests remain untouched). Also tested with the app, which has no problem. Unfortunately a small fix to the website is needed to allow people without a group to sign up from there.
This one is not as urgent as the last PR (#574), AFAIK not super important to get merged today. But it's thankfully much shorter.
Corresponding frontend change: