Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy - #198
Merged
shouze merged 2 commits intoSep 19, 2026
Merged
Conversation
Contributor
🔦 Lighthouse Report
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The consolidation feature appears fully removed across code, tests, completions, and docs with no remaining references found in the repository.
Review effort: Lite
Findings: None
What changed in this PR
This PR removes the deprecated consolidated-rendering mode for team-prefix grouping (--group-by-team-prefix-consolidate) end-to-end, aligning the CLI/TUI/replay/docs with the newer direction of resolving ambiguous combined sections via --pick-team (and supersession by --pick-team-auto in #199).
Changes:
- Removes the CLI flag, replay/TUI threading, and the underlying hierarchy-consolidation implementation and tests.
- Updates shell completions and docs to eliminate the option and its documentation section.
- Updates the pending
v2.0.0changelog summary to no longer mention consolidated rendering.
| File | Description |
|---|---|
| github-code-search.ts | Removes the CLI option, import/call, and replay/TUI plumbing for consolidation. |
| src/group.ts | Deletes consolidateTeamHierarchy/consolidateNode while keeping shared tree helpers. |
| src/group.test.ts | Removes unit tests and import coverage for the deleted consolidation feature. |
| src/output.ts | Removes consolidateTeamSections from replay options and replay-command emission. |
| src/output.test.ts | Removes replay-command tests that asserted the consolidation flag behavior. |
| src/tui.ts | Removes the consolidation parameter and stops forwarding it into output/replay. |
| src/completions.ts | Removes the completion entry for the deleted CLI flag. |
| src/completions.test.ts | Removes completion-script assertions for the deleted flag. |
| docs/usage/team-grouping.md | Deletes the “Advanced: consolidated rendering” docs section and related wording. |
| docs/reference/cli-options.md | Removes the CLI options table row for the deleted flag. |
| CHANGELOG.md | Updates the pending v2.0.0 summary to drop “consolidated rendering”. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Coverage after merging feat/team-hierarchy-remove-consolidate into feat/team-hierarchy-docs will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
--group-by-team-prefix-consolidateandconsolidateTeamHierarchyend-to-end. After using it in practice, this consolidated-rendering mode did not match the actual functional need — the real pain point is resolving ambiguous combined sections (e.g."gamme-lead-client + gamme-lead-client-p1") one by one via--pick-team, not the visual density of unambiguous single-branch chains. This option is superseded by--pick-team-auto(#199).github-code-search.ts: removed the CLI option, thegroupByTeamPrefixConsolidatefield, theconsolidateAppliedcomputation and its--format jsonwarning, and theconsolidateTeamHierarchyimport/call.src/group.ts: removedconsolidateTeamHierarchyandconsolidateNode. KeptassignLevels/pruneEmptyChildren— still used bynestOverlappingLabels/groupByTeamHierarchy.src/output.ts/src/tui.ts: removedconsolidateTeamSectionsfromReplayOptions,buildReplayCommand,buildOutput, andrunInteractive.src/completions.ts: removed the completion entry.CHANGELOG.md: updated the pendingv2.0.0summary.Closes #196.
How did you verify your code works?
bun test(977 passing),bun run lint,bun run format:check,bun run knip,bun run build.tsall green.grep -ri consolidatacross the repo.