Conversation
Contributor
|
Coverage after merging feat/team-hierarchy-pick-team-auto into feat/team-hierarchy-remove-consolidate will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
🔦 Lighthouse Report
|
Contributor
|
Coverage after merging feat/team-hierarchy-pick-team-auto into feat/team-hierarchy-remove-consolidate will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
autoPickTeamsByCommonPrefix() can silently skip resolving nested combined sections because it iterates combined paths in an order that can invalidate descendant paths after a parent resolution.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds a new --pick-team-auto flag to reduce manual --pick-team assignments by automatically resolving combined team sections when one candidate team name is a literal prefix of all others, and threads this flag through replay/interactive flows, completions, docs, and tests.
Changes:
- Introduces
autoPickTeamsByCommonPrefix()insrc/group.tsand wires it into the CLI flow (github-code-search.ts) after explicit--pick-teamresolutions. - Threads
pickTeamAutothrough replay command generation (src/output.ts) and interactive replay (src/tui.ts), with corresponding unit tests. - Updates shell completions and documentation to expose and explain
--pick-team-auto.
| File | Description |
|---|---|
| src/tui.ts | Threads pickTeamAuto into interactive replay options. |
| src/output.ts | Adds pickTeamAuto to ReplayOptions and emits --pick-team-auto in replay commands. |
| src/output.test.ts | Adds test coverage for replay-command emission and JSON replay threading. |
| src/group.ts | Adds auto-pick logic for resolving combined sections by common-prefix. |
| src/group.test.ts | Adds unit tests for auto-pick behavior across multiple scenarios and nesting. |
| src/completions.ts | Adds completion metadata for the new flag. |
| src/completions.test.ts | Verifies completion scripts include the new flag. |
| github-code-search.ts | Adds CLI flag, applies auto-pick, and threads it into output + interactive replay. |
| docs/usage/team-grouping.md | Documents the new auto-pick behavior and usage. |
| docs/reference/cli-options.md | Adds the CLI options table row for --pick-team-auto. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Auto-resolves a combined team section (e.g. "gamme-lead-client + gamme-lead-client-p1") to whichever team name is a literal prefix of every other team name in the combo, at any hierarchy depth. Combos with no common-prefix team are left combined/unresolved, and an explicit --pick-team for the same section always wins (auto-pick runs after explicit assignments). Closes #197
- Auto-nesting of an overlapping single-team label inserts an extra heading level beyond the declared chain depth (documents intended interaction of 2 separate mechanisms, not a bug). - A repo matching only a 2nd-level chain prefix (e.g. squad-) with no 1st-level match (gamme-) is invisible to that chain and falls through to a later independent chain (chapter-) instead. - --pick-team-auto correctly leaves combos unresolved when no single candidate is a literal prefix of every other candidate, even when several combos share some team members.
shouze
force-pushed
the
feat/team-hierarchy-pick-team-auto
branch
from
September 19, 2026 10:26
3542751 to
845771d
Compare
Contributor
|
Coverage after merging feat/team-hierarchy-pick-team-auto into feat/team-hierarchy-remove-consolidate will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
--pick-team-auto: automatically resolves combined team sections whose team names share a common prefix, at any hierarchy depth, without requiring an explicit--pick-team."a + b"), if exactly one team name is a literal string-prefix of every other team name in the combo (e.g.gamme-lead-clientfor"gamme-lead-client + gamme-lead-client-p1"), auto-resolve to that team."squad-frontend + squad-mobile") are left combined and unresolved — same as today,--pick-teamstill works for these.--pick-teamassignments, so an explicit pick for the same section always wins.src/group.ts: newautoPickTeamsByCommonPrefix(+ privatefindCommonPrefixTeamhelper).github-code-search.ts: new CLI flag, wired before the "unresolved combined sections" stderr note (now also triggered by--pick-team-auto).src/output.ts/src/tui.ts: threadedpickTeamAutothroughReplayOptions/buildReplayCommand/runInteractiveso a session using the flag replays identically.src/completions.ts: new completion entry.Closes #197. Depends on #198 (branch is stacked on top of it).
How did you verify your code works?
src/group.test.tscovering: single common-prefix winner, no common prefix (left combined), 3+-way combos (shortest-prefix wins), nested (non-top-level) sections, explicit-pick-wins-over-auto, purity, and no-op when nothing is combined.src/output.test.ts/src/completions.test.tsfor replay-command emission and completion scripts.bun test(990 passing),bun run lint,bun run format:check,bun run knip,bun run build.tsall green.