Navigate timeline images in the lightbox - #3489
Merged
Merged
Conversation
brsbl
added this pull request to stack #3490
September 11, 2026 15:55
brsbl
force-pushed
the
fix/timeline-image-navigation
branch
from
September 11, 2026 17:59
6608135 to
ec3f9b0
Compare
# Conflicts: # apps/app/src/components/thread/timeline/ThreadTimelineRows.tsx
danielbachhuber
added a commit
to danielbachhuber/bb
that referenced
this pull request
Sep 15, 2026
- markdown-preview.test.tsx: the only marked conflict, and it was adjacency in the import block. This branch added `onTestFinished` to the vitest import; main added `highlightMarkdownCode` on the next line. Both imports stay. - markdown-preview.tsx merged cleanly and needed no follow-up. Main's changes there came from the incremental streaming render (get-bb#3591) and the timeline lightbox work (get-bb#3489, get-bb#3596); none of them touch `MarkdownAnchor` or `MarkdownListItem`, so the fragment-link handling and the forwarded `<li id>` survive as written. - The incremental renderer does not undercut this fix. It treats `footnoteDefinition` and `footnoteReference` as global constructs (markdown-incremental-pieces.ts), so a message with footnotes is not split across pieces, and every piece renders inside the same `[data-markdown-preview]` root the destination lookup scopes to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Each inline Markdown image opened its own lightbox, preventing navigation between timeline images, including images inside tables.
What changed
How you verified
Current-head remote CI passed at
8cc1d9c75after integrating main.ec3f9b05c, including all five gallery regression tests.ec3f9b05cpassed inline/table navigation, loaded-page counts, lazy completed-turn expansion/collapse, image/backdrop dismissal, and desktop Escape.Before and after
These captures predate main integration. Refreshed exact-head screenshots remain pending.
Chrome for Testing 153.0.8010.36, exact branch web apps, the same synthetic timeline and table image, and light theme. Mobile: 390 × 844 CSS pixels; desktop: 1280 × 900. Every PNG is captured at 2× and inspected at full resolution.
Before:
6f1d89cfc. After:ec3f9b05c.Additional verified gallery states
Expanding completed-turn details adds the nested image. In this capture, scrolling also loaded the older page: five images total. Collapsing the turn again reduced the gallery to four.
Live streaming updates, CSS-clipped previews, and current-image retention are follow-on work. A separate, pre-existing desktop/mobile layout remount still closes open lightboxes; it also reproduces on the follow-on branch.
BB-Thread-ID: thr_rmv43jkeac