Keep timeline lightbox selection stable as images change - #3596
Merged
brsbl merged 15 commits intoSep 12, 2026
Merged
Conversation
…election # Conflicts: # apps/app/src/components/thread/timeline/ConversationMessageContent.tsx
brsbl
added this pull request to stack #3490
September 12, 2026 22:05
danielbachhuber
added a commit
to danielbachhuber/bb
that referenced
this pull request
Sep 15, 2026
- markdown-preview.test.tsx: the only marked conflict, and it was adjacency in the import block. This branch added `onTestFinished` to the vitest import; main added `highlightMarkdownCode` on the next line. Both imports stay. - markdown-preview.tsx merged cleanly and needed no follow-up. Main's changes there came from the incremental streaming render (get-bb#3591) and the timeline lightbox work (get-bb#3489, get-bb#3596); none of them touch `MarkdownAnchor` or `MarkdownListItem`, so the fragment-link handling and the forwarded `<li id>` survive as written. - The incremental renderer does not undercut this fix. It treats `footnoteDefinition` and `footnoteReference` as global constructs (markdown-incremental-pieces.ts), so a message with footnotes is not split across pieces, and every piece renders inside the same `[data-markdown-preview]` root the destination lookup scopes to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The gallery kept a stale image list and used rendered order to identify repeated images. Timeline updates could lose selection, expose clipped images, or leave navigation unavailable. Navigation wrapped at the ends, and disabled arrow taps dismissed the overlay.
What changed
How you verified
ab809c73d7c0292d94a36c1d44bedb86271a6bfc, including ten gallery regression cases.0bd3f0ce1.Final-candidate browser verification and refreshed screenshots remain unverified: the isolated dev-app route timed out twice. The user requested merging after this gap was reported. Earlier retention, expansion/collapse, and endpoint evidence does not establish final-candidate live streaming behavior.
Historical before and after
Same synthetic timeline, last image, disabled Next tap, and 390 × 844 CSS viewport at 2×. Before:
a20b3748c. After:0bd3f0ce1. These captures predate main integration and are not an exact parent/head comparison for this layer.BB-Thread-ID: thr_rmv43jkeac