Remove propagation of site description metadata to all pages - #787
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves metadata handling by removing the propagation of site-wide description and author metadata to all pages, preventing potential SEO issues from duplicate metadata. It also streamlines the generator metadata logic.
- Removes site-level author and description from default metadata to prevent identical metadata across all pages
- Simplifies generator metadata handling with inline conditional logic
- Makes Page metadata property writable by removing ReadonlyModelProperty attribute
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| formwork/src/Cms/Site.php | Removes author and description from default site metadata and streamlines generator metadata logic using ternary operator |
| formwork/src/Pages/Page.php | Removes ReadonlyModelProperty attribute from metadata property to allow modifications via the set() method |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the propagation of site description field as a
<meta name="description">to all pages, with the unintended result of potentially compromising search engine results with an identical description for each indexed page.The pull request also removes the propagation of site author field if present, which would result in the propagation of an author metadata identical for all pages.
The benefit of this change is higher than the risk of changing the previous behavior.
Metadata handling improvements:
generatormetadata field inSite.phpis now conditionally set based on thesystem.metadata.setGeneratorconfiguration value directly when building the defaults, eliminating redundant logic and making the code more concise.Codebase cleanup:
ReadonlyModelPropertyattribute was removed from themetadataproperty in thePageclass, possibly to allow for future modifications or to align with updated property handling conventions.