Skip to content

Remove propagation of site description metadata to all pages #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giuscris merged 1 commit into from
Nov 16, 2025
Merged

Remove propagation of site description metadata to all pages #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions formwork/src/Cms/Site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,18 +253,12 @@ public function metadata(): MetadataCollection
}

$defaults = [
'charset' => $this->config->get('system.charset'),
'author' => $this->get('author'),
'description' => $this->get('description'),
'generator' => 'Formwork',
'charset' => $this->config->get('system.charset'),
'generator' => $this->config->get('system.metadata.setGenerator') ? 'Formwork' : null,
];

$data = array_filter([...$defaults, ...$this->data['metadata']]);

if (!$this->config->get('system.metadata.setGenerator')) {
unset($data['generator']);
}

return $this->metadata = new MetadataCollection($data);
}

Expand Down
1 change: 0 additions & 1 deletion formwork/src/Pages/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ class Page extends Model implements Stringable
/**
* Page metadata
*/
#[ReadonlyModelProperty]
protected MetadataCollection $metadata;

/**
Expand Down