test(agent): an interruption is remembered as a fact, not as model speech - #145
Merged
Merged
Conversation
…eech
The template asserted that an interrupted turn left the line "La vuelta
se interrumpió." as the session's last turn. With milpa/app-runtime
0.183.1 and milpa/agent 0.50, the stream remembers an interruption as the
typed fact session.run_terminated {reason: interrupted}. No assistant turn
puts it in the model's mouth (greenhouse decisions/0466, 0996).
Measured on a fresh app with those versions: the old assertion is red,
and the new one is green along with the whole suite (181 tests, 26
skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greenhouse decisions/0466.
The template asserted that an interrupted turn left the Spanish line "La vuelta se interrumpió." as the last turn of the session. Since app-runtime 0.183.1 and milpa/agent 0.50, the stream records the typed fact
session.run_terminated {reason: interrupted}instead, and no assistant turn carries it.Measured on a fresh app with those versions: