Conversation
Contributor
|
I see this is a Draft, but just a few things not to forget about:
|
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Looking good, maybe drop the draft tag?
Member
|
Added the lint automation and fixes here: #214 |
BYK
requested changes
May 3, 2021
BYK
left a comment
Member
There was a problem hiding this comment.
I think these relative imports will fix the test issues. I'll look into why this is breaking separately.
Btw is it possible to have some tests for this target?
BYK
force-pushed
the
feat/upm
branch
3 times, most recently
from
May 5, 2021 18:20
874e2ca to
3004e1c
Compare
BYK
marked this pull request as ready for review
May 7, 2021 12:09
lobsterkatie
approved these changes
May 7, 2021
lobsterkatie
left a comment
Member
There was a problem hiding this comment.
Mostly just proofreading. (You can take the girl out of copyediting...) Otherwise LGTM!
Co-authored-by: Katie Byers <katie.byers@sentry.io>
Co-authored-by: Katie Byers <katie.byers@sentry.io>
BYK
enabled auto-merge (squash)
May 7, 2021 19:37
BYK
approved these changes
May 7, 2021
Member
|
Thanks a lot @BYK , @bitsandfoxes , @tonyo , @lobsterkatie !!! 🥳 🥳 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity SDK works in two repositories:
https://github.com/getsentry/sentry-unity <- SDK
https://github.com/getsentry/unity <- release repo for the user
Unity users add our package by providing a git URL to their package manager. Versioning and potential rollbacks for them are made available via tags (i.e. https://github.com/getsentry/unity.git#x.x.x).
Release steps: