Skip to content

ci: Reinstate linting and make it automatic - #214

Merged
BYK merged 16 commits into
masterfrom
byk/ci/lint
May 3, 2021
Merged

BYK merged 16 commits into
masterfrom
byk/ci/lint

Conversation

@BYK

@BYK BYK commented May 3, 2021

Copy link
Copy Markdown
Member

No description provided.

@BYK
BYK requested review from chadwhitacre, jan-auer and tonyo May 3, 2021 07:46
@BYK BYK closed this May 3, 2021
@BYK BYK reopened this May 3, 2021
@BYK BYK mentioned this pull request May 3, 2021

@jan-auer jan-auer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally speaking, it's unfortunate that it adds these parentheses, but I also understand the reasoning.

Please merge master and rerun the formatter to resolve conflicts.

Comment thread README.md Outdated
- Configure additional options (changelog management policy, tag prefix, etc.)

- List there all the targets you want to publish to
- Configure additional options (changelog management policy, tag prefix, etc.)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unintended.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, let me see how I can fix this.

Comment thread package.json Outdated
@jan-auer jan-auer changed the title ci: Reinstate lintin and make it automatic ci: Reinstate linting and make it automatic May 3, 2021
@BYK
BYK enabled auto-merge (squash) May 3, 2021 12:59
@BYK
BYK merged commit 6fdce47 into master May 3, 2021
@BYK
BYK deleted the byk/ci/lint branch May 3, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants