feat(schema): Add missing fields to DeviceContext - #1383
Conversation
Sync the DeviceContext with https://develop.sentry.dev/sdk/event-payloads/contexts/#device-context Adds `processor_count`, `cpu_description`, `processor_frequency`, `device_type`, `battery_status`, `device_unique_identifier`, `supports_vibration`, `supports_accelerometer`, `supports_gyroscope`, `supports_audio`, and `supports_location_service`.
jjbayer
left a comment
There was a problem hiding this comment.
@AbhiPrasad thanks for this! I think this matches @untitaker's
request from when the fields were documented: getsentry/develop#358 (review)
@untitaker Could you advise on what fields should have pii = "maybe"? Existing fields have it on most numeric fields but not on all string fields.
|
I think it's fine to add |
|
To clarify - I'll add the |
|
@AbhiPrasad Is there a usecase for scrubbing sensitive data from them? (=> maybe) Do sdks send PII in those fields by default? (=> true) |
|
Alright - made some changes based on that to the pii macro, but maybe @bruno-garcia can comment on this more |
| /// CPU description. | ||
| /// | ||
| /// For example, Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz. | ||
| #[metastructure(pii = "maybe")] |
There was a problem hiding this comment.
Not sure I'd mark this one as Maybe. Is this a thing? Where one could use the CPU desc to identify users?
There was a problem hiding this comment.
This has been a thing with fingerprinting - but not sure either. No harm to keep it maybe then, we can always change it to true or remove entirely afterwards.
There was a problem hiding this comment.
yeah I think "fingerprinting" is in scope for "maybe". If there is no attribute it is literally impossible to remove the value and that seems wrong as well.
While helping review getsentry/develop#658, I realized the context spec in the develop docs is out of sync with the struct in Relay.
This PR syncs the DeviceContext with https://develop.sentry.dev/sdk/event-payloads/contexts/#device-context
Adds
processor_count,cpu_description,processor_frequency,device_type,battery_status,device_unique_identifier,supports_vibration,supports_accelerometer,supports_gyroscope,supports_audio, andsupports_location_service.Another PR will be opened to update the other Contexts (and add
CultureContext)