Skip to content

fixing some errors from nextjs-source-map-updates branch - #14467

Merged
sfanahata merged 4 commits into
masterfrom
nextjs-source-map-fixes
Aug 26, 2025
Merged

sfanahata merged 4 commits into
masterfrom
nextjs-source-map-fixes

Conversation

@sfanahata

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

  • Fix enabled/disabled typo
  • Make clear that default: true is the default
  • Make clearer that source maps options are optional for set-up

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@sfanahata
sfanahata requested a review from chargome July 25, 2025 19:14
@vercel

vercel Bot commented Jul 25, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Aug 26, 2025 5:01pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Aug 26, 2025 5:01pm

@sfanahata

Copy link
Copy Markdown
Contributor Author

@chargome - adding the fixes I missed on the nextjs source maps repo.

cursor[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Jul 25, 2025 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 570 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.26MB 576 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.71kB -0.0%
static/chunks/1831-*.js -3 bytes 422.23kB -0.0%
static/oNe3R5CvH75Qq3qvG3z-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/oNe3R5CvH75Qq3qvG3z-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/ArR_RJs_UE6kebFdtMqx_/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ArR_RJs_UE6kebFdtMqx_/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 195 bytes 730.2kB 0.03%
../app/platform-redirect/page.js.nft.json 195 bytes 730.11kB 0.03%
../app/sitemap.xml/route.js.nft.json 195 bytes 727.59kB 0.03%

Comment thread platform-includes/sourcemaps/overview/javascript.nextjs.mdx Outdated
@sfanahata

Copy link
Copy Markdown
Contributor Author

@chargome - would love a plus one so I can merge this update.

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfanahata left a review earlier ⤴️

Otherwise looks good!

Comment thread platform-includes/sourcemaps/overview/javascript.nextjs.mdx Outdated
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@sfanahata
sfanahata merged commit 7693a15 into master Aug 26, 2025
13 checks passed
@sfanahata
sfanahata deleted the nextjs-source-map-fixes branch August 26, 2025 17:28
codyde added a commit that referenced this pull request Aug 29, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (72 commits)
  docs(replay): Bring replay nav item to all apple platforms (#14710)
  User Feedback Basics Page (#14670)
  Update AM3 and legacy billing for logs GA, DO NOT MERGE BEFORE LOGS GA (#14589)
  Add LLMSteering component for hidden documentation instructions (#14744)
  New data retention policy page (#14661)
  Adding error prediction to Prevent AI docs (#14641)
  feat(logs): Remove beta note from logs docs (#14686)
  First pass at logs quota doc (#14671)
  docs(aws): Remove manual setup steps for ESM (#14738)
  Android Logs docs without Errors / Breadcrumbs distractions (#14733)
  chore(Unity): Dropped 2019 relevant section from Known Limitations (#14735)
  feat: Added Unity `UserFeedback` Prefab (#14667)
  chore(Unity): Added Mono & Line Numbers to Known Limitations (#14736)
  docs(js): Fix Next.js client tracing config (#14734)
  chore: Updated known limitation in Unity with Cysharp (#14666)
  feat(Unity ): Added `APK+OBB` initialization to troubleshooting (#14668)
  Codecov copy & screenshot edits (#14659)
  fix(cloudflare): Remove unused instrument.mjs from hono on cloudflare (#14723)
  update advanced scrubbing doc - adding logs section (#14696)
  fixing some errors from nextjs-source-map-updates branch (#14467)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2025

This branch was successfully deployed

1 active deployment
Preview – sentry-docs — 873c2af7 Deployed Aug 26, 2025 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants