Repository navigation
Treat missing evals accounting as zero AIC - #60892
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix handling of missing file as 0 AIC for evals
Treat missing evals accounting as zero AIC
Sep 14, 2026
pelikhan
marked this pull request as ready for review
September 14, 2026 17:54
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Rerun attempts can fail producer validation before reaching the new zero-AIC fallback.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates daily AIC accounting so failed evals jobs without usage records contribute zero AIC.
Changes:
- Simplifies failed-evals accounting detection.
- Expands coverage for collection and upload failures.
- Removes obsolete step-name coupling documentation.
File summaries
| File | Description |
|---|---|
actions/setup/js/daily_aic_component_coverage.cjs |
Adds zero-AIC fallback for failed evals. |
actions/setup/js/daily_aic_component_coverage.test.cjs |
Covers missing accounting scenarios. |
pkg/workflow/evals_steps.go |
Removes obsolete comments. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+163
to
+168
| if (name === "evals" && job.conclusion === "failure") { | ||
| logComponentAIC(runId, name, job, 0, "failed_before_accounting", { | ||
| source: candidateStates[0].file, | ||
| }); | ||
| continue; | ||
| } |
This was referenced Sep 15, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily AIC guardrail failed when a failed evals job produced no
evals/token_usage.jsonl. Treat that case as zero AIC instead of an unknown accounting error.Accounting
0AIC.execution_not_startedprecedence when evidence exists.Coverage