Repository navigation
Preserve agent accounting in fallback artifacts - #61053
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
ARC/DinD fallback uploads still omit firewall accounting stored under the runner temporary directory.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open (1)
What changed in this PR
Preserves agent accounting when the primary agent artifact is unavailable.
Changes:
- Adds execution, engine usage, and firewall records to the fallback artifact.
- Extends compiler assertions for those paths.
- Adds a patch changeset.
| File | Description |
|---|---|
pkg/workflow/compiler_yaml_artifacts.go |
Adds accounting evidence to fallback uploads. |
pkg/workflow/compiler_artifacts_test.go |
Verifies generated fallback paths. |
.changeset/patch-preserve-agent-aic-fallback.md |
Documents the fix. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| constants.TmpGhAwDirSlash + "sandbox/firewall-audit-logs/api-proxy-logs/token-usage.jsonl", | ||
| constants.AWFProxyLogsDir.String() + "/api-proxy-logs/token-usage.jsonl", | ||
| constants.AWFAuditDir.String() + "/api-proxy-logs/token-usage.jsonl", |
|
@copilot Please take another pass on this PR and run the There is still an open Copilot review finding on the current work: preserve the fallback ARC/DinD artifact paths so runner temporary-directory firewall/accounting data is included when the primary agent artifact is unavailable. Please either push the follow-up fix or summarize the remaining blocker for maintainers. Recent review: Run: https://github.com/github/gh-aw/actions/runs/34939252893
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Fixed in |
|
Thanks @dsyme 👋 — this fix looks great! Preserving agent accounting in fallback artifacts when large agent artifacts are unavailable addresses a critical gap in observability for sampled agent runs. The clear description and focused scope make this easy to review. The lock file updates are expected given the workflow infrastructure changes. This is ready for review. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
🎉 This pull request is included in a new release. Release: |

Summary
agent-output-fallbackusageartifacttransient_errorThe missing evals accounting reported in #60870 was fixed by #60869 and #60892. This PR addresses the distinct missing-agent-accounting failure found during that investigation and the successful sampled-run case documented on #61052.
Closes #61052