Skip to content

chore: remove notify-parent workflow - #9

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes .github/workflows/notify-parent.yml — the parent meta repo's on-child-update.yml has been removed (gitkb/meta#60). These dispatch events go nowhere.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed a GitHub Actions workflow file.

The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e8d9594c-1f1a-493f-9100-f902ba980cc1

📥 Commits

Reviewing files that changed from the base of the PR and between 30e1e4d and daaa543.

📒 Files selected for processing (1)
  • .github/workflows/notify-parent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/notify-parent.yml

Walkthrough

The .github/workflows/notify-parent.yml workflow file has been deleted. This workflow previously triggered on pushes to main and repository_dispatch events, waiting for CI completion before notifying a parent repository via a dispatch event with commit and change metadata.

Changes

Cohort / File(s) Summary
Workflow Removal
.github/workflows/notify-parent.yml
Complete deletion of the parent repository notification workflow (96 lines removed).

Possibly related PRs

Poem

🐰 A workflow takes flight,
No more parent calls tonight,
Dispatches fade away,
Simplicity wins the day! ✨

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove notify-parent workflow' directly and accurately describes the main change: the removal of the .github/workflows/notify-parent.yml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-notify-parent

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the now-dead .github/workflows/notify-parent.yml workflow. Since harmony-labs/meta#60 deleted the receiving on-child-update.yml workflow, the child-repo-updated dispatch events had no handler and were silently dropped on every push to main.

  • Deleted: .github/workflows/notify-parent.yml — 96-line workflow that waited for CI, then dispatched child-repo-updated to harmony-labs/meta
  • No remaining references: Neither ci.yml nor auto-format.yml reference notify-parent.yml or the child-repo-updated event type
  • Security cleanup: PARENT_REPO_PAT secret is no longer referenced in any workflow, reducing the attack surface of unused credentials
  • repository_dispatch: dependency-updated preserved: ci.yml still listens for dependency-updated events — this is an orthogonal trigger for re-running CI when upstream dependencies change, and is unaffected by this removal

Confidence Score: 5/5

  • Safe to merge — pure deletion of a dead workflow with no downstream impact.
  • Single file deleted with clear, externally-verified justification (meta#60). No logic is changed, no secrets remain in use, and no other workflows reference the removed file. Zero regression risk.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/notify-parent.yml Workflow deleted entirely — dispatched child-repo-updated events to harmony-labs/meta, which no longer has a handler (meta#60). Removal is clean and well-justified.

Sequence Diagram

sequenceDiagram
    participant loop_cli as loop_cli (push to main)
    participant notify as notify-parent.yml ❌ removed
    participant meta as harmony-labs/meta<br/>(on-child-update.yml ❌ removed)

    Note over notify,meta: Previously — both ends now deleted
    loop_cli->>notify: triggers on push/repository_dispatch
    notify->>notify: wait-for-ci job
    notify->>meta: repository_dispatch: child-repo-updated
    meta-->>meta: on-child-update.yml handled event

    Note over loop_cli,meta: After this PR — no dispatch sent
    loop_cli->>loop_cli: push to main (no notification workflow)
Loading

Reviews (1): Last reviewed commit: "chore: remove notify-parent workflow" | Re-trigger Greptile

@mateodelnorte
mateodelnorte merged commit 9a5465a into main Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant