Skip to content

chore: remove on-child-update sync workflow - #60

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-child-sync-prs
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-child-sync-prs

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes .github/workflows/on-child-update.yml entirely.

Why

These sync PRs create empty commits (--allow-empty) on every child repo push to main. The parent meta repo doesn't build or test child repos — it's a workspace coordinator. The empty commits are pure noise and trigger release-please unnecessarily.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed the automated child repository synchronization workflow that previously managed pull request creation for child repository updates.

These sync PRs create empty commits on every child repo push to main.
The parent meta repo doesn't build or test child repos — it's a
workspace coordinator. The empty commits just create noise and trigger
release-please unnecessarily.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3119ae5e-1e89-4669-9918-fb07829ab00c

📥 Commits

Reviewing files that changed from the base of the PR and between d978541 and 619a05f.

📒 Files selected for processing (1)
  • .github/workflows/on-child-update.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/on-child-update.yml

Walkthrough

The entire .github/workflows/on-child-update.yml GitHub Actions workflow file was removed. This workflow previously listened for repository dispatch events to synchronize child repository changes, automatically creating branches and pull requests with auto-merge capabilities.

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/on-child-update.yml
Entire workflow deleted. Previously handled child repository synchronization logic including branch creation, PR management with auto-merge, and race condition handling via concurrency control.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A workflow once lived, so automated and spry,
Syncing child repos with a dutiful sigh,
But now it's removed—farewell, dear routine!
Simpler flows ahead for the garden scene! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the on-child-update workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-child-sync-prs

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes .github/workflows/on-child-update.yml, a workflow that listened for repository_dispatch events from child repos and responded by creating a branch, making an --allow-empty commit, opening a PR, and auto-merging it into main. Because on-push-main.yml runs release-please on every push to main, these empty commits were causing spurious release PRs with no actual changes.

  • The deletion is safe: no remaining workflow (ci.yml, on-push-main.yml, release.yml) references or depends on this workflow.
  • Child repos that still dispatch child-repo-updated events will simply receive a 204 No Content from GitHub — the event is silently ignored, no errors are surfaced on the child side.
  • The PARENT_REPO_PAT secret used exclusively by this workflow is now unused in the meta repo and can be cleaned up from repository settings as a follow-up.

Confidence Score: 5/5

  • Safe to merge — removes a single workflow file with no impact on remaining CI/CD pipelines.
  • This is a pure deletion of a self-contained workflow. No other workflow depends on it, the removal stops the noisy empty-commit pattern, and child repos that still dispatch the event will receive a harmless 204 response from GitHub. There are no logic errors, no missing updates to dependent files, and no risk of regression.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/on-child-update.yml Entirely removes the child-repo sync workflow that was creating empty commits on every child push to main, which was triggering release-please unnecessarily. Deletion is clean with no dependencies from remaining workflows.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Child Repo push to main] -->|repository_dispatch child-repo-updated| B{on-child-update.yml}
    B -->|REMOVED by this PR| C[Create sync/repo/sha branch]
    C --> D[git commit --allow-empty]
    D --> E[gh pr create]
    E --> F[Auto-merge PR]
    F --> G[Empty commit lands on meta/main]
    G --> H[on-push-main.yml triggers]
    H --> I[release-please runs unnecessarily]

    A2[Child Repo push to main] -->|repository_dispatch child-repo-updated| B2{No workflow listens}
    B2 -->|GitHub returns 204 No Content| C2[Event silently ignored ✅]

    style B fill:#ffcccc,stroke:#cc0000
    style C fill:#ffcccc,stroke:#cc0000
    style D fill:#ffcccc,stroke:#cc0000
    style E fill:#ffcccc,stroke:#cc0000
    style F fill:#ffcccc,stroke:#cc0000
    style G fill:#ffcccc,stroke:#cc0000
    style I fill:#ffcccc,stroke:#cc0000
    style B2 fill:#ccffcc,stroke:#00aa00
    style C2 fill:#ccffcc,stroke:#00aa00
Loading

Reviews (1): Last reviewed commit: "chore: remove on-child-update workflow" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant