fix: use feat: prefix in sync PR titles for release-please - #67
Conversation
Sync PRs from child repos used chore: prefix which release-please ignores. Changed to feat: so child repo updates trigger version bumps and homebrew releases.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR fixes a single-line issue in the child-repo sync workflow: the auto-created sync PRs were titled with a
Confidence Score: 5/5Safe to merge — single-line change with a clear, well-reasoned fix; the only feedback is a P2 style suggestion about semver semantics post-1.0.0. All findings are P2 (style/best-practice). The change is minimal, directly addresses the stated root cause, and is compatible with the existing squash-merge and release-please setup. No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/on-child-update.yml | Single-character prefix change from chore to feat in the sync PR title so release-please picks up the commit and triggers version bumps; fix is minimal and targeted. |
Sequence Diagram
sequenceDiagram
participant CR as Child Repo
participant GHA as on-child-update workflow
participant GH as GitHub (PR / squash merge)
participant RP as release-please (on-push-main)
participant REL as release workflow
CR->>GHA: repository_dispatch child-repo-updated
GHA->>GH: git push sync/repo/sha branch
GHA->>GH: gh pr create "feat(repo): sync sha"
GHA->>GH: gh pr merge --auto --squash
GH->>GH: squash commit → main<br/>"feat(repo): sync sha"
GH->>RP: push to main triggers on-push-main.yml
RP->>GH: create/update Release PR (version bump)
Note over RP,GH: Previously "chore:" was ignored here
GH-->>RP: Release PR merged
RP->>REL: release_created=true → trigger-release job
REL->>REL: build & publish homebrew release
Prompt To Fix All With AI
This is a comment left during a code review.
Path: .github/workflows/on-child-update.yml
Line: 38
Comment:
**`feat:` bumps minor after 1.0.0 — consider `fix:` for patch-only bumps**
Using `feat:` correctly triggers release-please (good!), but with `bump-minor-pre-major: true` / `bump-patch-for-minor-pre-major: true` the behavior changes once the project crosses `v1.0.0`:
- **Pre-1.0.0 today**: `feat:` is downgraded to a patch bump — identical to `fix:`.
- **Post-1.0.0**: `feat:` bumps the **minor** version on every child-repo sync, which may be more aggressive than intended for what is essentially a dependency-update commit.
If the intent is always a patch bump regardless of semver stage, `fix:` expresses that more precisely and keeps the behaviour consistent across the version boundary:
```suggestion
PR_TITLE="fix(${REPO_NAME}): sync ${SHORT_SHA}"
```
This is a style/semantics concern rather than a bug — `feat:` still achieves the stated goal of triggering releases — but worth being intentional about.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix: use feat: prefix in sync PR titles ..." | Re-trigger Greptile
|
|
||
| BRANCH="sync/${REPO_NAME}/${SHORT_SHA}" | ||
| PR_TITLE="chore(${REPO_NAME}): sync ${SHORT_SHA}" | ||
| PR_TITLE="feat(${REPO_NAME}): sync ${SHORT_SHA}" |
There was a problem hiding this comment.
feat: bumps minor after 1.0.0 — consider fix: for patch-only bumps
Using feat: correctly triggers release-please (good!), but with bump-minor-pre-major: true / bump-patch-for-minor-pre-major: true the behavior changes once the project crosses v1.0.0:
- Pre-1.0.0 today:
feat:is downgraded to a patch bump — identical tofix:. - Post-1.0.0:
feat:bumps the minor version on every child-repo sync, which may be more aggressive than intended for what is essentially a dependency-update commit.
If the intent is always a patch bump regardless of semver stage, fix: expresses that more precisely and keeps the behaviour consistent across the version boundary:
| PR_TITLE="feat(${REPO_NAME}): sync ${SHORT_SHA}" | |
| PR_TITLE="fix(${REPO_NAME}): sync ${SHORT_SHA}" |
This is a style/semantics concern rather than a bug — feat: still achieves the stated goal of triggering releases — but worth being intentional about.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/on-child-update.yml
Line: 38
Comment:
**`feat:` bumps minor after 1.0.0 — consider `fix:` for patch-only bumps**
Using `feat:` correctly triggers release-please (good!), but with `bump-minor-pre-major: true` / `bump-patch-for-minor-pre-major: true` the behavior changes once the project crosses `v1.0.0`:
- **Pre-1.0.0 today**: `feat:` is downgraded to a patch bump — identical to `fix:`.
- **Post-1.0.0**: `feat:` bumps the **minor** version on every child-repo sync, which may be more aggressive than intended for what is essentially a dependency-update commit.
If the intent is always a patch bump regardless of semver stage, `fix:` expresses that more precisely and keeps the behaviour consistent across the version boundary:
```suggestion
PR_TITLE="fix(${REPO_NAME}): sync ${SHORT_SHA}"
```
This is a style/semantics concern rather than a bug — `feat:` still achieves the stated goal of triggering releases — but worth being intentional about.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
chore:prefix which release-please ignoresfeat:so child repo updates trigger version bumps and homebrew releasesTest plan
feat(repo): sync ...title🤖 Generated with Claude Code
Summary by CodeRabbit