Skip to content

fix: use feat: prefix in sync PR titles for release-please #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateodelnorte merged 1 commit into from
Mar 29, 2026
Merged

fix: use feat: prefix in sync PR titles for release-please #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/on-child-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
SHORT_SHA="${SHORT_SHA:-$(date +%s | tail -c 8)}"

BRANCH="sync/${REPO_NAME}/${SHORT_SHA}"
PR_TITLE="chore(${REPO_NAME}): sync ${SHORT_SHA}"
PR_TITLE="feat(${REPO_NAME}): sync ${SHORT_SHA}"

@greptile-apps greptile-apps Bot Mar 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 feat: bumps minor after 1.0.0 — consider fix: for patch-only bumps

Using feat: correctly triggers release-please (good!), but with bump-minor-pre-major: true / bump-patch-for-minor-pre-major: true the behavior changes once the project crosses v1.0.0:

  • Pre-1.0.0 today: feat: is downgraded to a patch bump — identical to fix:.
  • Post-1.0.0: feat: bumps the minor version on every child-repo sync, which may be more aggressive than intended for what is essentially a dependency-update commit.

If the intent is always a patch bump regardless of semver stage, fix: expresses that more precisely and keeps the behaviour consistent across the version boundary:

Suggested change
PR_TITLE="feat(${REPO_NAME}): sync ${SHORT_SHA}"
PR_TITLE="fix(${REPO_NAME}): sync ${SHORT_SHA}"

This is a style/semantics concern rather than a bug — feat: still achieves the stated goal of triggering releases — but worth being intentional about.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/on-child-update.yml
Line: 38

Comment:
**`feat:` bumps minor after 1.0.0 — consider `fix:` for patch-only bumps**

Using `feat:` correctly triggers release-please (good!), but with `bump-minor-pre-major: true` / `bump-patch-for-minor-pre-major: true` the behavior changes once the project crosses `v1.0.0`:

- **Pre-1.0.0 today**: `feat:` is downgraded to a patch bump — identical to `fix:`.
- **Post-1.0.0**: `feat:` bumps the **minor** version on every child-repo sync, which may be more aggressive than intended for what is essentially a dependency-update commit.

If the intent is always a patch bump regardless of semver stage, `fix:` expresses that more precisely and keeps the behaviour consistent across the version boundary:

```suggestion
          PR_TITLE="fix(${REPO_NAME}): sync ${SHORT_SHA}"
```

This is a style/semantics concern rather than a bug — `feat:` still achieves the stated goal of triggering releases — but worth being intentional about.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


# Check for existing branch
if git ls-remote --exit-code origin "refs/heads/$BRANCH" >/dev/null 2>&1; then
Expand Down