Remove embedded meta agent subcommand - #24
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (6)
WalkthroughThis pull request removes the ChangesAgent module removal and CLI migration
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/init.rs (1)
394-396:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate stale comment to reflect GitKB organization.
The comment still mentions "Harmony Labs marketplace" but the implementation now registers the GitKB marketplace (line 421).
📝 Proposed fix
-/// Register the Harmony Labs marketplace with Claude Code (if available). +/// Register the GitKB marketplace with Claude Code (if available). /// This is best-effort — if `claude` is not on PATH, skip silently.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/init.rs` around lines 394 - 396, Update the stale doc comment above the conditional cfg(not(test)) block to say that the code registers the "GitKB marketplace" with Claude Code instead of "Harmony Labs marketplace"; locate the comment that starts "Register the Harmony Labs marketplace with Claude Code" in init.rs (adjacent to the cfg(not(test)) block/registration logic) and replace the old name so the comment accurately matches the implementation that registers the GitKB marketplace.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/init.rs`:
- Line 308: The PreToolUse hook invokes the external "agent" CLI via the "agent
guard" command but lacks an availability check or documentation; add a runtime
check like the existing claude availability pattern by attempting
Command::new("agent").arg("--version")... and set an agent_available flag (e.g.,
agent_available) to detect absence, then print a yellow warning with install
instructions when false; additionally, update the success/usage output near the
PreToolUse registration message to note that PreToolUse hooks require the
standalone "agent" CLI (install from gitkb/agent) so users are informed.
In `@src/registry.rs`:
- Around line 2038-2040: Replace the loose substring checks in
test_default_registry_points_to_gitkb with an exact equality assertion against
the canonical default registry URL: instead of
assert!(DEFAULT_REGISTRY.contains("gitkb")) /
assert!(DEFAULT_REGISTRY.contains("meta-plugins")), use
assert_eq!(DEFAULT_REGISTRY, "<expected-default-registry-URL>") (put the exact
URL string your project intends as the default). This ensures the
DEFAULT_REGISTRY constant is exactly the expected URL and prevents false
positives.
---
Outside diff comments:
In `@src/init.rs`:
- Around line 394-396: Update the stale doc comment above the conditional
cfg(not(test)) block to say that the code registers the "GitKB marketplace" with
Claude Code instead of "Harmony Labs marketplace"; locate the comment that
starts "Register the Harmony Labs marketplace with Claude Code" in init.rs
(adjacent to the cfg(not(test)) block/registration logic) and replace the old
name so the comment accurately matches the implementation that registers the
GitKB marketplace.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: eafa0e9c-75f2-46a3-a069-5c13ee361eb6
📒 Files selected for processing (12)
.claude/agent-guard.toml.claude/rules/meta-destructive-commands.md.github/workflows/auto-format.yml.github/workflows/ci.yml.github/workflows/notify-downstream.ymlCargo.tomlsrc/agent_guard.rssrc/agent_score.rssrc/init.rssrc/lib.rssrc/main.rssrc/registry.rs
💤 Files with no reviewable changes (6)
- Cargo.toml
- src/lib.rs
- src/agent_score.rs
- .claude/agent-guard.toml
- src/agent_guard.rs
- src/main.rs
6e4f32c to
ab34974
Compare
Summary
meta agentcommand group frommeta_cliagentprojectmeta init claudehook generation to callagent guarddirs,regex, andtomldependenciesVerification
cargo test -p metabats tests/init.bats./target/debug/meta --helpno longer listsagent./target/debug/meta agent guardexits unrecognizedTask: [[tasks/harmony-678]]
Summary by CodeRabbit
Documentation
Changes
meta agent guardtoagent guard; now requires standalone agent CLI