fix(ci): store regex in variables to fix notify-parent parse error - #18
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughReworks Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryFixes a bash parse error in the notify-parent workflow by storing regex patterns in variables before using them in
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/notify-parent.yml | Stores regex patterns in bash variables to prevent parse error in [[ =~ ]] tests, fixing cascading notification workflow |
Last reviewed commit: e87511d
b4d021f to
c6fe853
Compare
Bash interprets `(` in `[:(]` character classes as an unmatched subshell opener, causing "unexpected EOF while looking for matching ')'" (exit code 2). Storing the regex in a variable avoids this because bash passes variable content directly to the regex engine without shell parsing. Resolves [[incidents/notify-parent-broken]] Implements [[tasks/meta-64]] Co-authored-by: Claude <claude@anthropic.com>
c6fe853 to
bb2fbc6
Compare
Summary
[[ =~ ]]tests(in[:(]character class was interpreted as unmatched subshell openerunexpected EOF while looking for matching ')'(exit code 2)Root cause
Context
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Note: No user-facing changes in this release.