Skip to content

chore: remove notify-parent workflow - #21

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes .github/workflows/notify-parent.yml — the parent meta repo's on-child-update.yml has been removed (gitkb/meta#60). These dispatch events go nowhere.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed internal CI/CD workflow configuration.

The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c97bf689-3c90-46cb-a114-5b5320c91ed5

📥 Commits

Reviewing files that changed from the base of the PR and between c24b046 and 4143bc9.

📒 Files selected for processing (1)
  • .github/workflows/notify-parent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/notify-parent.yml

Walkthrough

This pull request removes the .github/workflows/notify-parent.yml GitHub Actions workflow file. The workflow previously orchestrated CI validation and sent parent repository notifications upon commits to the main branch or dependency updates via repository dispatch events.

Changes

Cohort / File(s) Summary
Workflow Deletion
.github/workflows/notify-parent.yml
Removed entire workflow file that triggered on push/repository_dispatch, waited for CI completion, parsed commit type from conventional prefixes, and dispatched notifications to parent repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A workflow once danced through the night,
Notifying parents with all its might,
But now it hops away, deleted clean—
The simplest change you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the notify-parent workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-notify-parent

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes the .github/workflows/notify-parent.yml CI workflow, which dispatched child-repo-updated repository-dispatch events to harmony-labs/meta after every push to main. The corresponding handler (on-child-update.yml) was already removed from the parent repo (gitkb/meta#60), making this workflow a no-op that only wastes CI minutes and burns the PARENT_REPO_PAT token on each push.

  • Deleted file: .github/workflows/notify-parent.yml — 96-line workflow composed of a wait-for-ci job (using lewagon/wait-on-check-action) and a notify-parent job (using peter-evans/repository-dispatch) that forwarded commit metadata to the parent meta repo.
  • No other workflows affected: The two remaining workflows (ci.yml, auto-format.yml) have no dependency on the removed workflow.
  • Clean deletion: No lingering references to PARENT_REPO_PAT or the removed dispatch logic anywhere in the repo.

Confidence Score: 5/5

  • Safe to merge — purely a dead workflow deletion with no code or functionality impact.
  • This is a single-file deletion of a workflow whose receiver was already removed upstream. There are no regressions possible, no other files reference the deleted workflow, and the PR description clearly links the upstream change that necessitates this cleanup.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/notify-parent.yml Deleted 96-line workflow that dispatched child-repo-updated events to harmony-labs/meta; removal is correct since the receiving handler in the parent repo was removed in gitkb/meta#60.

Sequence Diagram

sequenceDiagram
    participant Push as Push to main
    participant CI as wait-for-ci job
    participant Dispatch as notify-parent job
    participant Parent as harmony-labs/meta

    Note over Push,Parent: BEFORE this PR (now removed)
    Push->>CI: Trigger workflow
    CI->>CI: Wait for "Test (ubuntu-latest)" check
    CI->>Dispatch: On success
    Dispatch->>Parent: repository_dispatch: child-repo-updated
    Note over Parent: ❌ on-child-update.yml removed (meta#60)<br/>— event goes nowhere

    Note over Push,Parent: AFTER this PR
    Push->>Push: No notify-parent workflow exists<br/>— no wasted CI or PAT calls
Loading

Reviews (1): Last reviewed commit: "chore: remove notify-parent workflow" | Re-trigger Greptile

@mateodelnorte
mateodelnorte merged commit 2b2ab14 into main Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant