Skip to content

chore: remove notify-parent workflow - #5

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Removes .github/workflows/notify-parent.yml — the parent meta repo's on-child-update.yml has been removed (gitkb/meta#60). These dispatch events go nowhere.

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed automated parent repository notification workflow and CI coordination system.

The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d7404648-52e2-4616-aaf3-0c1ddb888a51

📥 Commits

Reviewing files that changed from the base of the PR and between 684191b and 85bbf90.

📒 Files selected for processing (1)
  • .github/workflows/notify-parent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/notify-parent.yml

Walkthrough

The GitHub Actions workflow .github/workflows/notify-parent.yml has been completely removed. This workflow previously handled CI gating, waited for CI checks to complete, and sent repository dispatch notifications to the parent repository with assembled payload data derived from commit messages or repository dispatch event metadata.

Changes

Cohort / File(s) Summary
Workflow Deletion
.github/workflows/notify-parent.yml
Complete removal of the CI gating and parent-repo notification workflow (96 lines deleted).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A workflow once fluttered, now gone with the breeze,
Notifications no longer dance through the trees,
The parent won't whisper of updates so grand,
But cleanup feels light, like dust blown from the sand! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove notify-parent workflow' accurately and concisely describes the main change: removal of the notify-parent.yml workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-notify-parent

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes .github/workflows/notify-parent.yml, a CI workflow that fired repository_dispatch events (type child-repo-updated) to the harmony-labs/meta parent repo after every push to main. Because the receiving handler (on-child-update.yml) was deleted from the parent repo in harmony-labs/meta#60, the dispatches were dead no-ops and the associated PARENT_REPO_PAT secret and CI wait step were running unnecessarily on every merge. The deletion is clean, complete, and consistent with the stated motivation.

  • Deleted: .github/workflows/notify-parent.yml (96 lines) — the only changed file.
  • Reason: Parent handler on-child-update.yml removed upstream; dispatch events had no receiver.
  • Remaining workflows: auto-format.yml and ci.yml are untouched and unaffected.
  • No issues found: The removal is intentional and leaves no dangling references in the repository.

Confidence Score: 5/5

  • Safe to merge — pure deletion of a dead workflow with no downstream impact.
  • Single-file deletion of a workflow whose upstream receiver has already been removed. No logic changes, no new code introduced, no secrets or config left dangling. The motivation is well-documented and cross-referenced to the parent repo PR.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/notify-parent.yml Workflow deleted in full; it dispatched child-repo-updated events to harmony-labs/meta on every push to main, a target that no longer has a handler since harmony-labs/meta#60 removed on-child-update.yml.

Sequence Diagram

sequenceDiagram
    participant PR as Push to main
    participant W as notify-parent.yml ❌ (removed)
    participant Meta as harmony-labs/meta<br/>(on-child-update.yml ❌ removed)

    PR->>W: triggers on push/branches: [main]
    W->>W: wait-for-ci (lewagon/wait-on-check-action)
    W->>W: determine source (extract commit metadata)
    W--xMeta: repository_dispatch: child-repo-updated<br/>(DEAD — no handler since meta#60)

    note over W,Meta: Both sides removed — PR cleans up this repo's half
Loading

Reviews (1): Last reviewed commit: "chore: remove notify-parent workflow" | Re-trigger Greptile

@mateodelnorte
mateodelnorte merged commit 057cafb into main Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant