Skip to content

chore: remove notify-parent workflow - #11

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes .github/workflows/notify-parent.yml — the parent meta repo's on-child-update.yml has been removed (gitkb/meta#60). These dispatch events go nowhere.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed internal repository notification workflow.

The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 45254638-a9ba-4af0-a7c3-65dcac75e815

📥 Commits

Reviewing files that changed from the base of the PR and between a23c7a7 and 9303ea3.

📒 Files selected for processing (1)
  • .github/workflows/notify-parent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/notify-parent.yml

Walkthrough

The GitHub Actions workflow file that notified a parent repository of child repository updates was completely removed from the codebase. The workflow previously triggered on main branch pushes and dependency updates to send repository dispatch events.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Removal
.github/workflows/notify-parent.yml
Removed workflow that coordinated CI checks and sent repository dispatch notifications to harmony-labs/meta with commit metadata and categorized change types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A workflow once whispered to distant repos,
With dispatches of news wherever code flows,
But now it's removed with a gentle goodbye,
No more parent notifications from way up high! 🌙

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the notify-parent workflow file. It is concise, clear, and directly reflects the primary action in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-notify-parent

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes .github/workflows/notify-parent.yml, a workflow that dispatched child-repo-updated repository-dispatch events to harmony-labs/meta after each push to main or on dependency-updated events. The corresponding receiver workflow in the parent repo was removed in harmony-labs/meta#60, making these dispatches dead-letter — so deleting this workflow is the correct clean-up.

  • Deleted the 96-line notify-parent.yml workflow entirely — no other files modified.
  • The PARENT_REPO_PAT secret is still referenced in .github/workflows/auto-format.yml as a checkout token to trigger downstream workflows on auto-format commits; this usage is unrelated to the parent-notification dispatch and continues to work correctly.
  • No remaining references to the removed notify-parent job, child-repo-updated event type, or harmony-labs/meta dispatch target exist in the repository.

Confidence Score: 5/5

  • Safe to merge — clean deletion of a dead workflow with no side-effects on remaining CI.
  • The change is a pure deletion of a workflow whose target receiver no longer exists. Remaining workflows are unaffected, and the only shared secret (PARENT_REPO_PAT) is still used correctly elsewhere for a different purpose.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/notify-parent.yml Deleted the 96-line workflow that dispatched child-repo-updated events to harmony-labs/meta; removal is correct since the parent receiver (on-child-update.yml) was removed in gitkb/meta#60.

Sequence Diagram

sequenceDiagram
    participant C as meta_project_cli<br/>(this repo)
    participant M as harmony-labs/meta<br/>(parent repo)

    Note over C,M: BEFORE this PR
    C->>C: push to main / dependency-updated
    C->>C: wait-for-ci (Test job)
    C->>M: repository_dispatch: child-repo-updated
    M--xC: ❌ on-child-update.yml removed (meta#60) — event goes nowhere

    Note over C,M: AFTER this PR
    C->>C: push to main
    Note over C: notify-parent.yml deleted<br/>No dispatch sent
Loading

Reviews (1): Last reviewed commit: "chore: remove notify-parent workflow" | Re-trigger Greptile

@mateodelnorte
mateodelnorte merged commit bf9ad34 into main Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant