Skip to content

chore: remove notify-parent workflow - #9

Merged
mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent
Mar 25, 2026
Merged

mateodelnorte merged 1 commit into
mainfrom
fix/remove-notify-parent

Conversation

@mateodelnorte

@mateodelnorte mateodelnorte commented Mar 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes .github/workflows/notify-parent.yml — the parent meta repo's on-child-update.yml has been removed (gitkb/meta#60). These dispatch events go nowhere.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed internal GitHub Actions automation workflow.

The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: db0c8f5a-d79c-46d9-a970-03edb82c5505

📥 Commits

Reviewing files that changed from the base of the PR and between 79af53a and 11f11d4.

📒 Files selected for processing (1)
  • .github/workflows/notify-parent.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/notify-parent.yml

Walkthrough

This pull request removes the entire GitHub Actions workflow file .github/workflows/notify-parent.yml, which previously automated notifications to a parent repository on specific events by triggering repository dispatches with commit metadata after verifying CI completion.

Changes

Cohort / File(s) Summary
Workflow Deletion
.github/workflows/notify-parent.yml
Removed entire workflow file that triggered parent repository notifications on main branch pushes and dependency-updated dispatch events. Workflow contained logic for wait-for-CI, commit classification via regex patterns, and repository dispatch to harmony-labs/meta with child repository update events.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A workflow departs on the wind,
No more dispatches sent in the night,
The notification chains unspinned,
Simplicity shines ever bright! 📨✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove notify-parent workflow' clearly and concisely describes the main change: removing the notify-parent workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-notify-parent

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Mar 25, 2026

Copy link
Copy Markdown

Greptile Summary

Removes .github/workflows/notify-parent.yml, the workflow responsible for dispatching child-repo-updated repository-dispatch events to harmony-labs/meta after each push to main. This is a clean housekeeping change coordinated with the removal of the receiver workflow in the parent repo (gitkb/meta#60), ensuring no dangling dispatch calls remain.

  • Deleted notify-parent.yml (96 lines): removes the wait-for-ci + notify-parent two-job pipeline that relayed push metadata (commit SHA, message, type, actor) upstream.
  • No other workflows (ci.yml, auto-format.yml) reference or depend on this file — the deletion is fully self-contained.
  • The PARENT_REPO_PAT secret used by the removed workflow is now unused; it can be cleaned up from repository secrets at a convenient time.

Confidence Score: 5/5

  • Safe to merge — pure deletion of a dead workflow with no remaining dependents.
  • Single-file deletion of a workflow whose upstream receiver was already removed. No logic changes, no remaining references, and the PR description clearly cites the coordinating parent-repo PR. The only minor follow-up (removing the now-unused PARENT_REPO_PAT secret) is non-blocking.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/notify-parent.yml Deleted workflow that dispatched child-repo-updated events to harmony-labs/meta. Safe to remove since the receiver (on-child-update.yml) was already removed in gitkb/meta#60.

Sequence Diagram

sequenceDiagram
    participant Repo as meta_rust_cli (push to main)
    participant NotifyWF as notify-parent.yml (REMOVED)
    participant ParentWF as harmony-labs/meta on-child-update.yml (REMOVED)

    Note over NotifyWF,ParentWF: Old flow — both ends now deleted
    Repo->>NotifyWF: triggers on push / repository_dispatch
    NotifyWF->>NotifyWF: wait-for-ci (lewagon/wait-on-check-action)
    NotifyWF->>ParentWF: repository-dispatch child-repo-updated (PARENT_REPO_PAT)
    ParentWF--xNotifyWF: receiver gone (harmony-labs/meta#60)

    Note over Repo: New flow — nothing dispatched upstream
Loading

Reviews (1): Last reviewed commit: "chore: remove notify-parent workflow" | Re-trigger Greptile

@mateodelnorte
mateodelnorte merged commit 7521073 into main Mar 25, 2026
8 checks passed
mateodelnorte added a commit that referenced this pull request Mar 26, 2026
The parent meta repo's on-child-update workflow has been removed —
these dispatch events go nowhere. The parent doesn't build or test
child repos; the sync PRs were empty noise.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mateodelnorte
mateodelnorte deleted the fix/remove-notify-parent branch March 26, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant