Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

node: add sequelize + express + opentelemetry sample app - #22

Merged
odeke-em merged 1 commit into
google:masterfrom
aabmass:sample-sequelize-express
Nov 11, 2020
Merged

odeke-em merged 1 commit into
google:masterfrom
aabmass:sample-sequelize-express

Conversation

@aabmass

@aabmass aabmass commented Nov 6, 2020

Copy link
Copy Markdown
Member

Depends on #26

Adds a sample app as an example for users. See README.md for details.

This sample lets you easily verify the OpenTelemetry integration is working. I will link to this sample in the documentation.

@aabmass
aabmass force-pushed the sample-sequelize-express branch 8 times, most recently from 6b0bf38 to 1dec6f5 Compare November 9, 2020 17:20
@aabmass
aabmass marked this pull request as ready for review November 9, 2020 17:21
@aabmass
aabmass force-pushed the sample-sequelize-express branch 2 times, most recently from 7ca6407 to 659fe8f Compare November 9, 2020 21:25

@odeke-em odeke-em left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @aabmass!

@aabmass
aabmass force-pushed the sample-sequelize-express branch from 659fe8f to 659d2c6 Compare November 10, 2020 19:08
@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Member Author

@odeke-em can you look at #26? This one should be merged after that one

@aabmass
aabmass force-pushed the sample-sequelize-express branch from 659d2c6 to 7b2262c Compare November 11, 2020 17:11
@aabmass
aabmass marked this pull request as draft November 11, 2020 17:20
@odeke-em

Copy link
Copy Markdown
Contributor

I've merged #26, please rebase from master and when ready I shall merge this one too. Thank you @aabmass.

@aabmass
aabmass force-pushed the sample-sequelize-express branch from 7b2262c to 8bb1cb9 Compare November 11, 2020 17:30
@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Member Author

Rebased :)

@aabmass
aabmass marked this pull request as ready for review November 11, 2020 17:33
Comment thread nodejs/sqlcommenter-nodejs/samples/express-opentelemetry/README.md Outdated
@aabmass
aabmass force-pushed the sample-sequelize-express branch from 8bb1cb9 to 381524f Compare November 11, 2020 18:19
@aabmass

aabmass commented Nov 11, 2020

Copy link
Copy Markdown
Member Author

Should be good to go

@odeke-em

Copy link
Copy Markdown
Contributor

Nice, thank you! Let me merge it.

@odeke-em
odeke-em merged commit 1bc1381 into google:master Nov 11, 2020
@aabmass
aabmass deleted the sample-sequelize-express branch November 11, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants