This repository was archived by the owner on May 29, 2026. It is now read-only.
node: add OpenTelemetry/OpenCensus deps to peerDependencies - #26
Merged
Merged
Conversation
aabmass
marked this pull request as ready for review
November 11, 2020 17:09
This was referenced Nov 11, 2020
odeke-em
approved these changes
Nov 11, 2020
Member
Author
|
Np! Btw, I can't merge these, is someone else supposed to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@opencensus/nodejs, @opencensus/propagation-tracecontext, and @opentelemetry/core are actually required at runtime, regardless of whether or not
tracestate/traceparentlabels are requested. See #23Adding to
peerDependenciesso that package using these sqlcommenter libraries would need to install these dependencies and then both packages would share that same version. I think in the long run, these dependencies should be optional and onlyrequire()d in the code paths that use these features.