Update NewsletterSignupCard styling for better responsiveness on small devices - #16702
Merged
georgerichmond merged 5 commits intoSep 14, 2026
Conversation
georgerichmond
force-pushed
the
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
branch
from
September 8, 2026 15:51
4aaea22 to
14fc024
Compare
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:21be5ec64bbd8a5f5a01f6636e0998362bdb8328a8b9ecad9ebd72d5c0b06283"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31075"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-dfae429efffd430b9333d61264db315adca210c6"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
georgerichmond
force-pushed
the
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
branch
from
September 8, 2026 15:55
14fc024 to
51da207
Compare
georgerichmond
force-pushed
the
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
branch
from
September 8, 2026 15:57
51da207 to
58cf0ef
Compare
georgerichmond
marked this pull request as ready for review
September 8, 2026 15:57
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
georgerichmond
force-pushed
the
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
branch
from
September 10, 2026 15:54
58cf0ef to
e96805d
Compare
…tyling-issue-on-small-devices
rBangay
approved these changes
Sep 14, 2026
Card top padding was space[3] (12px) while the badge row's margin-bottom was space[2] (8px), making the padding above and below the circular icon uneven. Align top padding to 8px to match. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tyling-issue-on-small-devices
georgerichmond
deleted the
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
branch
September 14, 2026 10:03
|
Seen on PROD (merged by @georgerichmond 7 minutes and 56 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the styling of the
NewsletterSignupCardheader to match the latest designWhy?
On small/narrow devices the frequency text ("Free newsletter | Around 2-3 times a day") could wrap awkwardly, and Dani created a new visual design (circular icon badge, bold frequency text, and a divider between the badge row and the heading).
How has this change been tested?
Styling-only change — verified manually in Storybook (
Defaultand newLongFrequencyNarrowstories) across mobile/wide viewports and in light/dark mode. Existing Storybook stories can be used for Chromatic visual regression testing.Screenshots
New
LongFrequencyNarrowstory, showing the text wrapping after the "|" divider with the icon centred against the two-line block: