Skip to content

Update NewsletterSignupCard styling for better responsiveness on small devices - #16702

Merged
georgerichmond merged 5 commits into
mainfrom
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices
Sep 14, 2026
Merged

Update NewsletterSignupCard styling for better responsiveness on small devices#16702
georgerichmond merged 5 commits into
mainfrom
1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices

Conversation

@georgerichmond

@georgerichmond georgerichmond commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Updates the styling of the NewsletterSignupCard header to match the latest design

Why?

On small/narrow devices the frequency text ("Free newsletter | Around 2-3 times a day") could wrap awkwardly, and Dani created a new visual design (circular icon badge, bold frequency text, and a divider between the badge row and the heading).

How has this change been tested?

Styling-only change — verified manually in Storybook (Default and new LongFrequencyNarrow stories) across mobile/wide viewports and in light/dark mode. Existing Storybook stories can be used for Chromatic visual regression testing.

Screenshots

Before After
before after
before2 after2

New LongFrequencyNarrow story, showing the text wrapping after the "|" divider with the icon centred against the two-line block:

long-frequency-narrow

@georgerichmond
georgerichmond force-pushed the 1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices branch from 4aaea22 to 14fc024 Compare September 8, 2026 15:51
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:21be5ec64bbd8a5f5a01f6636e0998362bdb8328a8b9ecad9ebd72d5c0b06283

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:21be5ec64bbd8a5f5a01f6636e0998362bdb8328a8b9ecad9ebd72d5c0b06283"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31075"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-dfae429efffd430b9333d61264db315adca210c6"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@georgerichmond
georgerichmond force-pushed the 1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices branch from 14fc024 to 51da207 Compare September 8, 2026 15:55
@georgerichmond georgerichmond self-assigned this Sep 8, 2026
@georgerichmond georgerichmond added Bug feature Departmental tracking: work on a new feature and removed Bug labels Sep 8, 2026
@georgerichmond
georgerichmond force-pushed the 1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices branch from 51da207 to 58cf0ef Compare September 8, 2026 15:57
@georgerichmond
georgerichmond marked this pull request as ready for review September 8, 2026 15:57
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

@georgerichmond georgerichmond added the run_chromatic Runs chromatic when label is applied label Sep 8, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 8, 2026
@georgerichmond
georgerichmond force-pushed the 1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices branch from 58cf0ef to e96805d Compare September 10, 2026 15:54
@georgerichmond georgerichmond added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
Comment thread dotcom-rendering/src/components/NewsletterSignupCard.tsx
@georgerichmond
georgerichmond added this pull request to the merge queue Sep 14, 2026
@georgerichmond
georgerichmond removed this pull request from the merge queue due to a manual request Sep 14, 2026
Card top padding was space[3] (12px) while the badge row's
margin-bottom was space[2] (8px), making the padding above and below
the circular icon uneven. Align top padding to 8px to match.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@georgerichmond georgerichmond added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@georgerichmond
georgerichmond added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 9262ef1 Sep 14, 2026
27 checks passed
@georgerichmond
georgerichmond deleted the 1024-bug-newsletter-in-article-signup-card-styling-issue-on-small-devices branch September 14, 2026 10:03
@gu-prout

gu-prout Bot commented Sep 14, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @georgerichmond 7 minutes and 56 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants