Skip to content

Update NewsletterSignupCard styling for better responsiveness on small devices #16702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgerichmond merged 5 commits into from
Sep 14, 2026
+100 −32
Merged

Update NewsletterSignupCard styling for better responsiveness on small devices #16702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9297e7a
Update NewsletterSignupCard styling for better responsiveness on smal…
georgerichmond Sep 8, 2026
e96805d
Make image smaller on small mobile and line wider
georgerichmond Sep 10, 2026
3d641b9
Merge branch 'main' into 1024-bug-newsletter-in-article-signup-card-s…
georgerichmond Sep 14, 2026
9ee82b5
Fix uneven vertical spacing above/below newsletter frequency badge
georgerichmond Sep 14, 2026
dfae429
Merge branch 'main' into 1024-bug-newsletter-in-article-signup-card-s…
georgerichmond Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions dotcom-rendering/src/components/NewsletterSignupCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,25 @@ export const Default = meta.story({
children: <></>,
},
});

/**
* Demonstrates a longer frequency string in a narrow container, to show that
* the text breaks after the "|" divider rather than wrapping mid-word.
*/
export const LongFrequencyNarrow = meta.story({
args: {
name: 'Breaking News US',
description: 'Get the most important news as it breaks.',
frequency: 'Around 2-3 times a day',
illustrationSquare:
'https://media.guim.co.uk/10b4e02333ee97ecf51d5e814fd324a88832fb17/1177_0_2998_3000/2998.jpg',
children: <></>,
},
decorators: [
(Story) => (
<div css={{ maxWidth: 300 }}>
<Story />
</div>
),
],
});
98 changes: 68 additions & 30 deletions dotcom-rendering/src/components/NewsletterSignupCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
headlineMedium20,
space,
textSans14,
textSans15,
textSansBold15,
} from '@guardian/source/foundations';
import { SvgNewsletterFilled } from '@guardian/source/react-components';
import { palette as themePalette } from '../palette';
Expand All @@ -22,7 +22,7 @@ export type NewsletterSignupCardProps = {
const containerStyles = css`
clear: left;
background-color: ${themePalette('--newsletter-card-background')};
padding: ${space[3]}px ${space[3]}px ${space[4]}px ${space[3]}px;
padding: ${space[2]}px ${space[3]}px ${space[4]}px ${space[3]}px;
`;

const dividerStyles = css`
Expand Down Expand Up @@ -55,34 +55,64 @@ const titleStyles = css`
const frequencyTagStyles = css`
display: flex;
align-items: center;
gap: 6px;
Comment thread
georgerichmond marked this conversation as resolved.
color: ${themePalette('--newsletter-card-frequency-tag')};
${textSans15};
margin-left: -1px;
margin-top: -1px;
margin-bottom: ${space[1]}px;
${textSansBold15};
margin-bottom: ${space[2]}px;
`;

const frequencyTextStyles = css`
display: flex;
flex-wrap: wrap;
column-gap: ${space[1]}px;
`;

const frequencyLabelStyles = css`
white-space: nowrap;
`;

const badgeStyles = css`
display: flex;
align-items: center;
justify-content: center;
flex-shrink: 0;
width: 24px;
height: 24px;
border-radius: 50%;
background-color: ${themePalette('--newsletter-card-badge-background')};

svg {
fill: currentColor;
height: 20px;
width: 20px;
fill: ${themePalette('--newsletter-card-badge-icon')};
height: 18px;
width: 18px;
}
`;

const innerDividerStyles = css`
border: none;
border-top: 1px solid ${themePalette('--newsletter-card-divider')};
margin: 0 -${space[3]}px ${space[2]}px;
`;

const descriptionStyles = css`
${textSans14};
line-height: 1.15;
margin-bottom: ${space[2]}px;
clear: both;
color: ${themePalette('--newsletter-card-description')};
`;

const illustrationStyles = css`
flex-shrink: 0;
width: 90px;
height: 90px;
width: 70px;
height: 70px;
border-radius: 50%;
object-fit: cover;

${from.mobileMedium} {
width: 90px;
height: 90px;
}

${from.tablet} {
width: 100px;
height: 100px;
Expand All @@ -92,27 +122,35 @@ const illustrationStyles = css`
const NewsletterSignupHeader = (
props: Omit<NewsletterSignupCardProps, 'children'>,
) => (
<div css={headerStyles}>
<div css={titleAndMetaStyles}>
<div css={frequencyTagStyles}>
<>
<div css={frequencyTagStyles}>
<span css={badgeStyles}>
<SvgNewsletterFilled />
Free newsletter | {props.frequency}
</span>
<span css={frequencyTextStyles}>
<span css={frequencyLabelStyles}>Free newsletter |</span>
<span css={frequencyLabelStyles}>{props.frequency}</span>
</span>
</div>
<hr css={innerDividerStyles} />
<div css={headerStyles}>
<div css={titleAndMetaStyles}>
<p css={titleStyles}>
Sign up to <span>{props.name}</span>
</p>
<p css={descriptionStyles}>{props.description}</p>
</div>
<p css={titleStyles}>
Sign up to <span>{props.name}</span>
</p>
<p css={descriptionStyles}>{props.description}</p>
{!!props.illustrationSquare && (
<img
css={illustrationStyles}
src={props.illustrationSquare}
alt=""
loading="lazy"
decoding="async"
/>
)}
</div>
{!!props.illustrationSquare && (
<img
css={illustrationStyles}
src={props.illustrationSquare}
alt=""
loading="lazy"
decoding="async"
/>
)}
</div>
</>
);

export const NewsletterSignupCard = ({
Expand Down
12 changes: 10 additions & 2 deletions dotcom-rendering/src/paletteDeclarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7969,6 +7969,14 @@ const paletteColours = {
light: () => '#F3F7FF',
dark: () => sourcePalette.brand[100],
},
'--newsletter-card-badge-background': {
light: () => sourcePalette.brand[400],
dark: () => sourcePalette.brand[600],
},
'--newsletter-card-badge-icon': {
light: () => sourcePalette.neutral[100],
dark: () => sourcePalette.neutral[100],
},
'--newsletter-card-description': {
light: () => sourcePalette.neutral[20],
dark: () => sourcePalette.neutral[86],
Expand All @@ -7978,8 +7986,8 @@ const paletteColours = {
dark: () => sourcePalette.neutral[46],
},
'--newsletter-card-frequency-tag': {
light: () => sourcePalette.neutral[38],
dark: () => sourcePalette.neutral[73],
light: () => sourcePalette.brand[400],
dark: () => sourcePalette.neutral[100],
},
'--newsletter-card-title': {
light: () => sourcePalette.neutral[7],
Expand Down
Loading